Bug 31411 - Web Inspector: breakpoint sidebar entries should allow click over entire list item
Summary: Web Inspector: breakpoint sidebar entries should allow click over entire list...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-12 08:08 PST by Patrick Mueller
Modified: 2009-11-12 09:08 PST (History)
8 users (show)

See Also:

proposed patch 2009/11/12 - a (2.69 KB, patch)
2009-11-12 08:16 PST, Patrick Mueller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Mueller 2009-11-12 08:08:12 PST
Currently, the breakpoint sidebar list only allows you to click on the first line of breakpoint entry to "switch to" the source of that breakpoint.  It would be nicer if the entire list item, which includes the source text, was also "clickable" to be able to switch to the source of the entry.
Comment 1 Patrick Mueller 2009-11-12 08:16:50 PST
Created attachment 43064 [details]
proposed patch 2009/11/12 - a

For a breakpoint list item in the breakpoints sidebar:

- change the label/link, which contained the sourceURL and line number, to just a text node, and remove the click event
- add a click event to the breakpointElement itself
- change the name of the labelClicked handler to breakpointClicked
- change the checkboxClicked handler to stop propogation, otherwise breakpointClick will be inadvertently invoked as well
Comment 2 WebKit Commit Bot 2009-11-12 09:08:09 PST
Comment on attachment 43064 [details]
proposed patch 2009/11/12 - a

Clearing flags on attachment: 43064

Committed r50881: <http://trac.webkit.org/changeset/50881>
Comment 3 WebKit Commit Bot 2009-11-12 09:08:13 PST
All reviewed patches have been landed.  Closing bug.