Bug 314069 – [WebXR Layers] Crashes in OpenXRLayer's endFrame() for various layer types

• Status: RESOLVED
• Resolution: FIXED
• Component: WebXR

[Sergio Villar Senin]

OpenXRxxxLayer::endFrame() crashes in releaseImage() because acquireImage() (called inside beginFrame() via populateFrameData()) was never called for that layer in the current frame.

The root cause is that beginFrame() is called from inside renderLoop(), which is called from the submitFrame() dispatch. At that point activeLayerHandles contains the **previous** frame's layer list. The new layer added by applyPendingRenderState() is only reflected in activeLayerHandles when the **next** scheduleAnimationFrame() dispatch runs which is always too late. Something like this

 submitFrame dispatch → endFrame() → renderLoop() → beginFrame()
                                                      ↑ snapshots OLD activeLayerHandles
 scheduleAnimationFrame dispatch → activeLayerHandles = FRESH → renderLoop()
                                                                  ↑ pendingFrame=true, exits early

There is a clear mismatch between the layers known by WebXR and the ones used by OpenXR to render

[Sergio Villar Senin]

Pull request: https://github.com/WebKit/WebKit/pull/64370

[EWS]

Committed 312788@main (b0baaeaf0cd8): <https://commits.webkit.org/312788@main>

Reviewed commits have been landed. Closing PR #64370 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/176446755>