Bug 31394 - [Chromium] Sify compose button alerts error
Summary: [Chromium] Sify compose button alerts error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-12 00:00 PST by Adam Barth
Modified: 2009-11-28 08:39 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2009-11-12 00:14 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (1.16 KB, patch)
2009-11-12 01:32 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2009-11-12 02:21 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (3.91 KB, patch)
2009-11-12 09:31 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2009-11-12 09:32 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-11-12 00:00:40 PST
1) Go to sify.com
2) Sign in
3) Click compose

Notice that there is an error alert in Chrome but not in Safari.  Turns out this is related to lexical versus dynamic scope when doing access checks.

I'm currently debugging the issue.
Comment 1 Adam Barth 2009-11-12 00:14:53 PST
Created attachment 43037 [details]
Patch
Comment 2 Adam Barth 2009-11-12 01:32:32 PST
Created attachment 43045 [details]
Patch
Comment 3 Adam Barth 2009-11-12 02:21:32 PST
Created attachment 43046 [details]
Patch
Comment 4 Sam Weinig 2009-11-12 09:15:58 PST
Comment on attachment 43046 [details]
Patch

> Index: LayoutTests/ChangeLog
> ===================================================================
> --- LayoutTests/ChangeLog	(revision 50871)
> +++ LayoutTests/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> +2009-11-12  Adam Barth  <abarth@webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Chromium] Actually declare getPluginMimeTypeFromExtension in a header
> +        https://bugs.webkit.org/show_bug.cgi?id=30985

I don't think this is the title you meant to add.
Comment 5 Adam Barth 2009-11-12 09:31:16 PST
Created attachment 43067 [details]
Patch
Comment 6 Adam Barth 2009-11-12 09:32:48 PST
Created attachment 43068 [details]
Patch
Comment 7 WebKit Commit Bot 2009-11-12 11:56:11 PST
Comment on attachment 43068 [details]
Patch

Clearing flags on attachment: 43068

Committed r50890: <http://trac.webkit.org/changeset/50890>
Comment 8 WebKit Commit Bot 2009-11-12 11:56:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Dimitri Glazkov (Google) 2009-11-13 07:22:15 PST
This regressed inspector and is a beta blocker.  See https://bugs.webkit.org/show_bug.cgi?id=31467 for more details.

We'll need to roll this patch out if we can't find a solution today.
Comment 10 Pavel Feldman 2009-11-13 09:12:08 PST
Reverted:

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	LayoutTests/http/tests/security/calling-versus-current-expected.txt
	D	LayoutTests/http/tests/security/calling-versus-current.html
	M	LayoutTests/ChangeLog
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8Proxy.cpp
Committed r50946
Comment 11 Adam Barth 2009-11-28 08:39:20 PST
Committed r51459: <http://trac.webkit.org/changeset/51459>