Bug 31392 - ARIA: add alert type roles
Summary: ARIA: add alert type roles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-11 22:49 PST by chris fleizach
Modified: 2009-11-12 09:37 PST (History)
2 users (show)

See Also:


Attachments
patch (12.22 KB, patch)
2009-11-11 23:02 PST, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-11-11 22:49:32 PST
Add alert, alertdialog, dialog roles
Comment 1 chris fleizach 2009-11-11 23:02:47 PST
Created attachment 43032 [details]
patch

This makes alert, alertdialog, dialog into similar AXGroups on the mac like the other ARIA landmark type roles.

It looks like when I run webkit-updated-localized-strings, it caught a missing string from a past check in
Comment 2 chris fleizach 2009-11-11 23:03:42 PST
there's also a spelling error in the "Tab panel" description. i'll get that
Comment 3 chris fleizach 2009-11-12 09:26:32 PST
adding to commit queue since i'm at work and code is at home
Comment 4 WebKit Commit Bot 2009-11-12 09:37:48 PST
Comment on attachment 43032 [details]
patch

Clearing flags on attachment: 43032

Committed r50883: <http://trac.webkit.org/changeset/50883>
Comment 5 WebKit Commit Bot 2009-11-12 09:37:51 PST
All reviewed patches have been landed.  Closing bug.