Bug 31391 – SVNTest.test_svn_apply may fail in different timezone

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Shinichiro Hamaji]

svn-apply sets TZ=PST8PDT but SVNTest.test_svn_apply doesn't change this. This can cause unittest failure.

[Shinichiro Hamaji]

Created attachment 43028 [details]
Patch v1

[Eric Seidel (no email)]

Comment on attachment 43028 [details]
Patch v1

Isn't there a cleaner fix w/o using os.environ?  I would think Date would have some sort of timezone adjustment methods...

[Shinichiro Hamaji]

If nothing changed after I did similar stuff with Python (and as far as I searched webs now), I think there are no easy way to do this. If I understand correctly, Python provides a framework to convert datetime object among different timezones, but it doesn't provide information of actual timezones. Like following blog post, we need to provide information of each timezone by ourselves.

http://uswaretech.com/blog/2009/02/understanding-datetime-tzinfo-timedelta-timezone-conversions-python/

There seems to be a library which provides information of timezones, but it seems not to be the standard library.

http://pytz.sourceforge.net/

I think my patch would be OK as prepare-ChangeLog is doing the same thing after all and it's just a test.

Another idea to fix this is adding an --date flag into prepare-ChangeLog and use this flag in this unittest. If you prefer this approach, I'll do the fix.

Of course, if I'm missing something and there is a better way, I'd like to use the way.

[Tim 'mithro' Ansell]

This bug was fixed by [e-mail] in r93257
 http://trac.webkit.org/changeset/93257

*** This bug has been marked as a duplicate of bug 65877 ***