WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
313839
[CMake] Fix macOS build after
312428@main
by adding rendering/cocoa to WebCore include dirs
https://bugs.webkit.org/show_bug.cgi?id=313839
Summary
[CMake] Fix macOS build after 312428@main by adding rendering/cocoa to WebCor...
zak ridouh
Reported
2026-05-01 12:40:37 PDT
Commit
312428@main
([WebCore] Fix underlying build errors hidden by UnifiedBuild files) added a direct `#include "RenderThemeCocoa.h"` in Source/WebCore/page/InteractionRegion.cpp, which is gated on ENABLE(FORM_CONTROL_REFRESH). RenderThemeCocoa.h lives in Source/WebCore/rendering/cocoa, but that directory was never part of WebCore_PRIVATE_INCLUDE_DIRECTORIES, so the Mac CMake port fails with: Source/WebCore/page/InteractionRegion.cpp:79:10: fatal error: 'RenderThemeCocoa.h' file not found The Xcode build happened to find the header via its own header search paths, so the problem only shows up in the CMake Mac port. Add rendering/cocoa to WebCore_PRIVATE_INCLUDE_DIRECTORIES in PlatformMac.cmake so the header resolves the same way the sibling rendering/mac directory's headers already do (via -I from other paths).
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-05-01 12:40:43 PDT
<
rdar://problem/176042265
>
zak ridouh
Comment 2
2026-05-01 12:42:55 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/64057
EWS
Comment 3
2026-05-01 14:00:09 PDT
Committed
312448@main
(077d9a850018): <
https://commits.webkit.org/312448@main
> Reviewed commits have been landed. Closing PR #64057 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug