RESOLVED FIXED31383
[V8] De-inline lots of V8Bindings functions to save 450k of code 
https://bugs.webkit.org/show_bug.cgi?id=31383
Summary [V8] De-inline lots of V8Bindings functions to save 450k of code
Jens Alfke
Reported 2009-11-11 15:43:22 PST
De-inlining a bunch of V8Bindings' utility functions that are used ubiquitously by the generated V8 bindings, saves about 450k of code. For the most part these simply had their bodies moved intact from the .h to the .cpp file, but I added a few small speed optimizations after looking at Shark profile data, e.g. in v8ExternalString. This includes: v8DOMWrapperToNative v8ValueToWebCoreString v8ValueToAtomicWebCoreString toInt32 toWebCoreString toWebCoreStringWithNullCheck toAtomicWebCoreStringWithNullCheck toWebCoreStringWithNullOrUndefinedCheck isUndefinedOrNull v8Boolean v8UndetectableString v8StringOrNull v8StringOrUndefined v8StringOrFalse v8StringToWebCoreString v8ExternalString And a new function: createRawTemplate
Attachments
patch (25.73 KB, patch)
2009-11-11 16:03 PST, Jens Alfke 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jens Alfke
Comment 1 2009-11-11 16:03:04 PST
Created attachment 43017 [details] patch
Jens Alfke
Comment 2 2009-11-11 16:11:38 PST
Committed revision 50846.
Note You need to log in before you can comment on or make changes to this bug.