Bug 31382 – Make -webkit-color-correction work with shadows

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Beth Dakin]

New CSS feature -webkit-color-correction does not currently work with box-shadow or text-shadow. This should be rectified!

[Beth Dakin]

Created attachment 43015 [details]
Patch

A few things about this patch:

1. As I mention in the Changelog, this doesn't fix canvas shadows. I will fix those when I fix canvas <https://bugs.webkit.org/show_bug.cgi?id=31319>
2. I did not make a new variable on the state for the shadow ColorSpace. This is not necessary with the way things are currently implemented. Furthermore, I realized that it is probably silly to have both a strokeColorSpace and a fillColorSpace -- I am pretty certain that even when the colors are different, stroke and fill will have the same ColorSpace, right? Anyway, it seems like these could be collapsed into one variable. I did not do that with the patch, but I am considering it. Maybe now or maybe later, what do you think?

[Simon Fraser (smfr)]

Comment on attachment 43015 [details]
Patch

> Index: WebCore/platform/graphics/cg/GraphicsContextCG.cpp
> ===================================================================

> +    CGColorRef cgColor = NULL;

Should be 0, not NULL. It would be nice to rewrite this using RetainPtrs at some point.

[Simon Fraser (smfr)]

Comment on attachment 43015 [details]
Patch

r++++++

[Beth Dakin]

Yay! Committed fix with revision 50852.