Bug 31371 - SharedWorkerRepository.connect() does not call WebSharedWorkerRepository
Summary: SharedWorkerRepository.connect() does not call WebSharedWorkerRepository
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
Depends on:
Reported: 2009-11-11 13:05 PST by Andrew Wilson
Modified: 2009-11-11 13:23 PST (History)
1 user (show)

See Also:

proposed patch (1.48 KB, patch)
2009-11-11 13:10 PST, Andrew Wilson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-11-11 13:05:03 PST
In a recent refactoring, we changed how the chromium version of SharedWorkerRepository.connect() works, but left out a call to WebKitSharedWorkerRepository.addSharedWorker().

This causes SharedWorkers to not get shutdown properly when the document exits.
Comment 1 Andrew Wilson 2009-11-11 13:10:06 PST
Created attachment 42994 [details]
proposed patch

This is the upstreamed version of the change to SharedWorkerRepository from http://codereview.chromium.org/390017.
Comment 2 WebKit Commit Bot 2009-11-11 13:23:09 PST
Comment on attachment 42994 [details]
proposed patch

Clearing flags on attachment: 42994

Committed r50838: <http://trac.webkit.org/changeset/50838>
Comment 3 WebKit Commit Bot 2009-11-11 13:23:12 PST
All reviewed patches have been landed.  Closing bug.