Bug 31368 - [V8] De-inline large method convertNodeToV8Object
Summary: [V8] De-inline large method convertNodeToV8Object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Enhancement
Assignee: Jens Alfke
URL:
Keywords:
Depends on:
Blocks: 31217
  Show dependency tree / graph
 
Reported: 2009-11-11 12:27 PST by Jens Alfke
Modified: 2009-11-12 16:25 PST (History)
0 users

See Also:

Attachments
path fix (1.49 KB, text/plain)
2009-11-11 12:50 PST, Yaar Schnitman 		no flags Details
patch (2.79 KB, patch)
2009-11-11 13:02 PST, Jens Alfke 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Alfke 2009-11-11 12:27:36 PST 
The method V8DOMWrapper::convertNodeToV8Object is declared as inline, and there are 136 calls to it in the generated V8 bindings. It's a fairly complex piece of code that expands to a lot of machine instructions. De-inlining it helps shrink the bindings.
Comment 1 Yaar Schnitman 2009-11-11 12:50:30 PST 
Created attachment 42991 [details]
path fix
Comment 2 Yaar Schnitman 2009-11-11 12:52:11 PST 
Comment on attachment 42991 [details]
path fix

Please ignore.
Comment 3 Jens Alfke 2009-11-11 13:02:55 PST 
Created attachment 42993 [details]
patch
Comment 4 Dimitri Glazkov (Google) 2009-11-11 13:04:24 PST 
Comment on attachment 42993 [details]
patch

awesome.
Comment 5 Jens Alfke 2009-11-11 13:10:10 PST 
Committed revision 50835.