RESOLVED FIXED 31367
[V8] Make bindings return NULL handles instead of calling v8::Undefined(). 
https://bugs.webkit.org/show_bug.cgi?id=31367
Summary [V8] Make bindings return NULL handles instead of calling v8::Undefined().
Jens Alfke
Reported 2009-11-11 11:44:19 PST
The generated code for V8 bindings uses "return v8::Undefined()" when it needs to return from the binding without a specific return value (e.g. on error, or if the result is undefined.) This results in a function call. V8 interprets a return value of an empty/NULL handle as being the same as Undefined(), so I've changed the bindings to do that. This makes the bindings slightly smaller and faster, as there are many instances of this construct.
Attachments
patch (4.25 KB, patch)
2009-11-11 11:47 PST, Jens Alfke 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jens Alfke
Comment 1 2009-11-11 11:47:21 PST
Created attachment 42986 [details] patch
Dimitri Glazkov (Google)
Comment 2 2009-11-11 11:51:40 PST
Comment on attachment 42986 [details] patch r=me. Thanks!
Jens Alfke
Comment 3 2009-11-11 11:53:40 PST
Committed revision 50831.
Note You need to log in before you can comment on or make changes to this bug.