Bug 31361 - WebInspector: Tests for Layout, Paint, ParseHTML, MarkTimeline, Style Recalculation
Summary: WebInspector: Tests for Layout, Paint, ParseHTML, MarkTimeline, Style Recalcu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-11 10:43 PST by Eric Ayers
Modified: 2009-11-11 13:35 PST (History)
5 users (show)

See Also:


Attachments
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline (9.29 KB, patch)
2009-11-11 11:03 PST, Eric Ayers
pfeldman: review-
Details | Formatted Diff | Diff
WebInspector: Adds another script tag test for WebInspector timeline records. (10.37 KB, patch)
2009-11-11 11:43 PST, Eric Ayers
pfeldman: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline (9.28 KB, patch)
2009-11-11 12:16 PST, Eric Ayers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Ayers 2009-11-11 10:43:17 PST
These tests are all pretty simple - they find the timeline record of interest and dump it.
Comment 1 Eric Ayers 2009-11-11 11:03:10 PST
Created attachment 42979 [details]
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline
Comment 2 Pavel Feldman 2009-11-11 11:13:33 PST
Comment on attachment 42979 [details]
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline

> +        if (record.type == timelineAgentRecordType.Layout) {

Please use ===

> +    if (record.type == timelineAgentRecordType.MarkTimeline && record.data.message == timelineMark) {

ditto

> +        if (found =findMarkTimeline(record))

space after =

> +        if (record.type == timelineAgentRecordType.Paint) {

ditto

> +        if (record.type == timelineAgentRecordType.ParseHTML) {

ditto

> +        if (record.type == timelineAgentRecordType.RecalculateStyles) {

ditto

r- for style, rest seems to be fine.
Comment 3 Eric Ayers 2009-11-11 11:43:29 PST
Created attachment 42985 [details]
WebInspector: Adds another script tag test for WebInspector timeline records.

Fixes style problems noted in review feedback of previous patch.
Comment 4 Pavel Feldman 2009-11-11 11:53:59 PST
Comment on attachment 42985 [details]
WebInspector: Adds another script tag test for WebInspector timeline records.

=findMarkTimeline is still there, please fix with the next patch.
Comment 5 WebKit Commit Bot 2009-11-11 12:00:48 PST
Comment on attachment 42985 [details]
WebInspector: Adds another script tag test for WebInspector timeline records.

Rejecting patch 42985 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Pavel Feldman', '--force']" exit_code: 1
Last 500 characters of output:
sts/inspector/timeline-paint.html
patching file LayoutTests/inspector/timeline-parse-html-expected.txt
patching file LayoutTests/inspector/timeline-parse-html.html
patching file LayoutTests/inspector/timeline-recalculate-styles-expected.txt
patching file LayoutTests/inspector/timeline-recalculate-styles.html
patching file LayoutTests/inspector/timeline-test.js
Hunk #1 FAILED at 39.
Hunk #2 FAILED at 127.
2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/inspector/timeline-test.js.rej
Comment 6 Eric Ayers 2009-11-11 12:16:50 PST
Created attachment 42988 [details]
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline

fixed style problem and rebased patch.
Comment 7 WebKit Commit Bot 2009-11-11 13:35:51 PST
Comment on attachment 42988 [details]
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline

Clearing flags on attachment: 42988

Committed r50839: <http://trac.webkit.org/changeset/50839>
Comment 8 WebKit Commit Bot 2009-11-11 13:35:55 PST
All reviewed patches have been landed.  Closing bug.