These tests are all pretty simple - they find the timeline record of interest and dump it.
Created attachment 42979 [details] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline
Comment on attachment 42979 [details] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline > + if (record.type == timelineAgentRecordType.Layout) { Please use === > + if (record.type == timelineAgentRecordType.MarkTimeline && record.data.message == timelineMark) { ditto > + if (found =findMarkTimeline(record)) space after = > + if (record.type == timelineAgentRecordType.Paint) { ditto > + if (record.type == timelineAgentRecordType.ParseHTML) { ditto > + if (record.type == timelineAgentRecordType.RecalculateStyles) { ditto r- for style, rest seems to be fine.
Created attachment 42985 [details] WebInspector: Adds another script tag test for WebInspector timeline records. Fixes style problems noted in review feedback of previous patch.
Comment on attachment 42985 [details] WebInspector: Adds another script tag test for WebInspector timeline records. =findMarkTimeline is still there, please fix with the next patch.
Comment on attachment 42985 [details] WebInspector: Adds another script tag test for WebInspector timeline records. Rejecting patch 42985 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Pavel Feldman', '--force']" exit_code: 1 Last 500 characters of output: sts/inspector/timeline-paint.html patching file LayoutTests/inspector/timeline-parse-html-expected.txt patching file LayoutTests/inspector/timeline-parse-html.html patching file LayoutTests/inspector/timeline-recalculate-styles-expected.txt patching file LayoutTests/inspector/timeline-recalculate-styles.html patching file LayoutTests/inspector/timeline-test.js Hunk #1 FAILED at 39. Hunk #2 FAILED at 127. 2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/inspector/timeline-test.js.rej
Created attachment 42988 [details] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline fixed style problem and rebased patch.
Comment on attachment 42988 [details] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline Clearing flags on attachment: 42988 Committed r50839: <http://trac.webkit.org/changeset/50839>
All reviewed patches have been landed. Closing bug.