RESOLVED FIXED 31354
[Chromium] Remove WebViewImpl::dragSourceMovedTo() 
https://bugs.webkit.org/show_bug.cgi?id=31354
Summary [Chromium] Remove WebViewImpl::dragSourceMovedTo()
Nate Chapin
Reported 2009-11-11 08:45:40 PST
http://trac.webkit.org/changeset/50786 removed EventHandler::dragSourceMovedTo(), which WebViewImpl in the Chormium API uses. Should just be a straight delete.
Attachments
patch (1.38 KB, patch)
2009-11-11 08:47 PST, Nate Chapin 		no flags
DetailsFormatted DiffDiff
patch2 (1.99 KB, patch)
2009-11-11 09:56 PST, Nate Chapin 		eric: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2009-11-11 08:47:45 PST
Created attachment 42964 [details] patch
Dimitri Glazkov (Google)
Comment 2 2009-11-11 08:48:57 PST
Comment on attachment 42964 [details] patch r=me, but you should really mention the changeset that removed it in the ChangeLog.
Nate Chapin
Comment 3 2009-11-11 09:07:05 PST
http://trac.webkit.org/changeset/50808
Nate Chapin
Comment 4 2009-11-11 09:56:11 PST
Created attachment 42973 [details] patch2 Missed a couple of references...
Nate Chapin
Comment 5 2009-11-11 09:56:38 PST
Missed some references, new patch attached.
Eric Seidel (no email)
Comment 6 2009-11-11 10:01:31 PST
Comment on attachment 42973 [details] patch2 LGTM.
Adam Barth
Comment 7 2009-11-12 18:50:07 PST
Comment on attachment 42964 [details] patch This claims to have been landed.
WebKit Commit Bot
Comment 8 2009-11-12 19:07:07 PST
Comment on attachment 42973 [details] patch2 Rejecting patch 42973 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 patching file WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/chromium/src/WebViewImpl.h Hunk #1 FAILED at 127. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/WebViewImpl.h.rej patching file WebKit/chromium/public/WebView.h Hunk #1 FAILED at 167. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebView.h.rej
Nate Chapin
Comment 9 2009-11-13 09:16:22 PST
Sorry about that. I forgot that I hadn't closed this bug :-(
Note You need to log in before you can comment on or make changes to this bug.