Bug 31339 - Fix incorrect white-space in WebGLRenderingContext.idl
Summary: Fix incorrect white-space in WebGLRenderingContext.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P5 Normal
Assignee: Berend-Jan Wever
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-11 01:58 PST by Berend-Jan Wever
Modified: 2010-04-07 09:53 PDT (History)
3 users (show)

See Also:


Attachments
Patch that removes the offending white-space. (809 bytes, patch)
2009-11-11 01:58 PST, Berend-Jan Wever
eric: review-
Details | Formatted Diff | Diff
[PATCH] Remove Whitespace (1.47 KB, patch)
2010-04-07 08:45 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Berend-Jan Wever 2009-11-11 01:58:54 PST
Created attachment 42939 [details]
Patch that removes the offending white-space.

WebGLRenderingContext.idl declares "drawElements" incorrectly: there is additional white-space after the method name.

        void         drawElements (in unsigned long mode, in long count, in unsigned long type, in unsigned long offset);
                                ^^^

This can cause an IDL parser to see it as an unnamed method that returns "void drawElements", which is incorrect.

Oliver, can you apply this patch for me?
Comment 1 Eric Seidel (no email) 2009-11-11 08:43:22 PST
Comment on attachment 42939 [details]
Patch that removes the offending white-space.

This needs a ChangeLog, but otherwise looks fine.

prepare-ChangeLog -b 31339

should generate what you want.
Comment 2 Joseph Pecoraro 2010-04-06 23:13:45 PDT
SkyLined, the space still exists. Did you want to redo this patch? Like Eric mentions, you just need a ChangeLog. Or, if you would rather I attach a patch for you, let me know.
Comment 3 Berend-Jan Wever 2010-04-07 01:12:27 PDT
If you could create a patch for me, that would be great! I'm prioritizing a bunch of other things, so I won't get to do this myself anytime soon. But it would make my life easier later on, so I would really like to see the change.

Thanks!
Comment 4 Joseph Pecoraro 2010-04-07 08:45:26 PDT
Created attachment 52740 [details]
[PATCH] Remove Whitespace
Comment 5 Joseph Pecoraro 2010-04-07 08:45:58 PDT
(In reply to comment #3)
> If you could create a patch for me, that would be great! I'm prioritizing a
> bunch of other things, so I won't get to do this myself anytime soon. But it
> would make my life easier later on, so I would really like to see the change.

Let me know if there are any other issues that you find!
Comment 6 WebKit Commit Bot 2010-04-07 09:53:45 PDT
Comment on attachment 52740 [details]
[PATCH] Remove Whitespace

Clearing flags on attachment: 52740

Committed r57214: <http://trac.webkit.org/changeset/57214>
Comment 7 WebKit Commit Bot 2010-04-07 09:53:49 PDT
All reviewed patches have been landed.  Closing bug.