WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
313373
[TestWebKitAPI] Use framework-style include for WebCoreTestSupport.h
https://bugs.webkit.org/show_bug.cgi?id=313373
Summary
[TestWebKitAPI] Use framework-style include for WebCoreTestSupport.h
David Kilzer (:ddkilzer)
Reported
2026-04-26 17:12:34 PDT
Ten TestWebKitAPI source files use `#import "WebCoreTestSupport.h"` (quoted include), which relies on `WebCoreTestSupport.h` being found via a `BUILT_PRODUCTS_DIR`-relative header search path. In Production builds where test support headers are installed to `$(SDK_DIR)/usr/local/include/WebCoreTestSupport/`, the quoted include fails because the header is not at the expected path. Use `#import <WebCoreTestSupport/WebCoreTestSupport.h>` (framework-style include) instead, matching the installed directory layout. The system header search paths already include `$(SDK_DIR)/usr/local/include`, so the `WebCoreTestSupport/` prefix resolves correctly in both local engineering builds and Production builds.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-04-26 17:13:35 PDT
<
rdar://problem/175638226
>
David Kilzer (:ddkilzer)
Comment 2
2026-04-26 17:17:46 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/63652
EWS
Comment 3
2026-04-27 07:43:32 PDT
Committed
312094@main
(3b8f24768a08): <
https://commits.webkit.org/312094@main
> Reviewed commits have been landed. Closing PR #63652 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug