WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31328
Remove unused DWORD id member from Windows PlatformThread
https://bugs.webkit.org/show_bug.cgi?id=31328
Summary
Remove unused DWORD id member from Windows PlatformThread
Laszlo Gombos
Reported
2009-11-10 17:01:00 PST
id (DWORD type) field from the PlatformThread structure is not used in Collector.cpp; I propose to remove the field and simplify the code. This is the first proposed step in a larger refactoring effort to make the multiple JavaScriptCore Threads implementation more portable so that is is available for more ports. As a secondary target we might be able to remove the pthread library dependency for WIN_OS.
Attachments
proposed patch
(2.60 KB, patch)
2009-11-10 17:08 PST
,
Laszlo Gombos
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2009-11-10 17:08:55 PST
Created
attachment 42912
[details]
proposed patch
Eric Seidel (no email)
Comment 2
2009-11-11 09:45:40 PST
This code was last touched in
http://trac.webkit.org/changeset/35440
. CCing the authors of that change.
Alexey Proskuryakov
Comment 3
2009-11-11 09:57:22 PST
Comment on
attachment 42912
[details]
proposed patch r=me
WebKit Commit Bot
Comment 4
2009-11-11 12:00:17 PST
Comment on
attachment 42912
[details]
proposed patch Clearing flags on attachment: 42912 Committed
r50833
: <
http://trac.webkit.org/changeset/50833
>
WebKit Commit Bot
Comment 5
2009-11-11 12:00:25 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug