Bug 31328 - Remove unused DWORD id member from Windows PlatformThread
Summary: Remove unused DWORD id member from Windows PlatformThread
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-10 17:01 PST by Laszlo Gombos
Modified: 2009-11-11 12:00 PST (History)
4 users (show)

See Also:

proposed patch (2.60 KB, patch)
2009-11-10 17:08 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-11-10 17:01:00 PST
id (DWORD type) field from the PlatformThread structure is not used in Collector.cpp; I propose to remove the field and simplify the code.

This is the first proposed step in a larger refactoring effort to make the multiple JavaScriptCore Threads implementation more portable so that is is available for more ports. As a secondary target we might be able to remove the pthread library dependency for WIN_OS.
Comment 1 Laszlo Gombos 2009-11-10 17:08:55 PST
Created attachment 42912 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2009-11-11 09:45:40 PST
This code was last touched in http://trac.webkit.org/changeset/35440.  CCing the authors of that change.
Comment 3 Alexey Proskuryakov 2009-11-11 09:57:22 PST
Comment on attachment 42912 [details]
proposed patch

Comment 4 WebKit Commit Bot 2009-11-11 12:00:17 PST
Comment on attachment 42912 [details]
proposed patch

Clearing flags on attachment: 42912

Committed r50833: <http://trac.webkit.org/changeset/50833>
Comment 5 WebKit Commit Bot 2009-11-11 12:00:25 PST
All reviewed patches have been landed.  Closing bug.