RESOLVED FIXED 31327
Clean up SocketStreamHandleClient interface 
https://bugs.webkit.org/show_bug.cgi?id=31327
Summary Clean up SocketStreamHandleClient interface
Alexey Proskuryakov
Reported 2009-11-10 16:57:37 PST
Patch with comments forthcoming.
Attachments
proposed patch (5.21 KB, patch)
2009-11-10 17:02 PST, Alexey Proskuryakov 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-11-10 17:02:33 PST
Created attachment 42911 [details] proposed patch We should add a comment explaining what the difference between close() and disconnect() is. It's not sufficiently clear to me yet.
Fumitoshi Ukai
Comment 2 2009-11-11 00:57:58 PST
(In reply to comment #1) > Created an attachment (id=42911) [details] > proposed patch > > We should add a comment explaining what the difference between close() and > disconnect() is. It's not sufficiently clear to me yet. disconnect() is used before WebSocketChannelClient is deleted, because it won't receive didClose() anymore. On the other hand, close() will imply didClose() that will be called back later.
Alexey Proskuryakov
Comment 3 2009-11-11 09:23:36 PST
Committed <http://trac.webkit.org/changeset/50811> > disconnect() is used before WebSocketChannelClient is deleted, because it won't > receive didClose() anymore. > On the other hand, close() will imply didClose() that will be called back > later. Thank you - I added a comment about the difference.
Note You need to log in before you can comment on or make changes to this bug.