Bug 31326 - Make the output prettier for test /fast/events/drag-and-drop.html
Summary: Make the output prettier for test /fast/events/drag-and-drop.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks: 30291
  Show dependency treegraph
 
Reported: 2009-11-10 16:32 PST by Daniel Bates
Modified: 2009-11-11 21:47 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.51 KB, patch)
2009-11-10 16:35 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2009-11-10 16:32:49 PST
Following up an a suggestion made by Darin on bug #30291, we should make the output of the test /fast/events/drag-and-drop.html pretty and easy to read by a human.
Comment 1 Daniel Bates 2009-11-10 16:35:43 PST
Created attachment 42908 [details]
Patch

Changed one line in test case from shouldEvaluateTo('event.dataTransfer.dropEffect',...) to shouldBeEqualToString('event.dataTransfer.dropEffect', ...).

Rebased the results.
Comment 2 Eric Seidel (no email) 2009-11-10 16:36:53 PST
Comment on attachment 42908 [details]
Patch

LGTM.
Comment 3 Daniel Bates 2009-11-11 21:47:02 PST
Comment on attachment 42908 [details]
Patch

Clearing flags on attachment: 42908

Committed r50866: <http://trac.webkit.org/changeset/50866>
Comment 4 Daniel Bates 2009-11-11 21:47:10 PST
All reviewed patches have been landed.  Closing bug.