WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
313181
[Site Isolation] Replace parentFrameSecurityOrigin with precomputed bool in NavigationRequester
https://bugs.webkit.org/show_bug.cgi?id=313181
Summary
[Site Isolation] Replace parentFrameSecurityOrigin with precomputed bool in N...
Anthony Tarbinian
Reported
2026-04-23 16:08:07 PDT
Follows up on
https://commits.webkit.org/311805@main
by replacing the RefPtr<SecurityOrigin> parentFrameSecurityOrigin field with a bool parentOriginIsSameAsTopOrigin. The origin was only used in isNavigationBlockedByThirdPartyIFrameRedirectBlocking to check isSameOriginDomain against the top frame's origin. Since NavigationRequester already carries topOrigin, precompute the comparison at capture time in NavigationRequester::from() instead of carrying a RefPtr<SecurityOrigin>. Based on this review comment
https://github.com/WebKit/WebKit/pull/61712#discussion_r3126415219
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-04-23 16:08:13 PDT
<
rdar://problem/175463992
>
Anthony Tarbinian
Comment 2
2026-04-23 16:12:49 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/63479
EWS
Comment 3
2026-04-24 20:16:15 PDT
Committed
312002@main
(fac0cb3cde15): <
https://commits.webkit.org/312002@main
> Reviewed commits have been landed. Closing PR #63479 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug