Bug 31316 – Clean up color-correction code on Windows

Bug 31316 - Clean up color-correction code on Windows


Summary:	Clean up color-correction code on Windows

Status:	NEW

Product:	WebKit
Classification:	Unclassified
Component:	CSS
Version:	528+ (Nightly build)
Platform:	PC OS X 10.5

Importance:	P2 Normal
Assigned To:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-11-10 14:20 PST by Beth Dakin
Modified:	2009-12-08 15:20 PST (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Beth Dakin 2009-11-10 14:20:11 PST

I just committed a patch making -webkit-color-correction work for CSS Colors <https://bugs.webkit.org/show_bug.cgi?id=31196>. It broke with Windows build, and I got bweinstein to help me fix it <http://trac.webkit.org/changeset/50764>. Since we were primarily concerned with getting the build working again, I told him just to send DeviceColorSpace to setFillColor() and setStrokeColor(). All of the call sites he modified need to be revisited because that is probably not the correct solution.

Comment 1 Beth Dakin 2009-11-11 20:32:58 PST

In addition to fixing the aforementioned call-sites, we also need to re-enable the feature! Unfortunately we had to disable it because of a CG bug. Once the bug is fixed, we need to re-enable and fix these call sites.

See <https://bugs.webkit.org/show_bug.cgi?id=31363> for details of disabling.

Comment 2 Beth Dakin 2009-11-11 20:33:21 PST

<rdar://problem/7387791> Make -webkit-color-correction correct color on Windows

Comment 3 Beth Dakin 2009-12-08 15:20:49 PST

Turns out Windows renders in sRGB all the time! So this feature would be a no-op on Windows even if it was properly implemented. 

No work needs to be done for this to work, but we should still clean up the code and adjust all of the FIXMEs to reflect the new information that we have.