Bug 31312 - Decouple authentication panel callbacks from ResourceHandle
Summary: Decouple authentication panel callbacks from ResourceHandle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-10 14:03 PST by Alexey Proskuryakov
Modified: 2009-11-10 14:39 PST (History)
0 users

See Also:


Attachments
proposed patch (28.41 KB, patch)
2009-11-10 14:11 PST, Alexey Proskuryakov
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-11-10 14:03:39 PST
SocketStream also wants to ask the user about credentials. For now, it's just proxy credentials.

Patch forthcoming.
Comment 1 Alexey Proskuryakov 2009-11-10 14:11:57 PST
Created attachment 42893 [details]
proposed patch
Comment 2 mitz 2009-11-10 14:25:20 PST
Comment on attachment 42893 [details]
proposed patch

> + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
> + * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
> + */
> +#ifndef AuthenticationClient_h
> +#define AuthenticationClient_h

There should be an empty line before the #ifndef. Also, this is not the latest version of the license Apple uses (see <http://webkit.org/coding/bsd-license.html> and <http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.h> for a comment-formatted version).

r=me
Comment 3 Alexey Proskuryakov 2009-11-10 14:39:23 PST
Committed <http://trac.webkit.org/changeset/50772>.