Bug 31296 – Web Inspector: Should support console.groupCollapsed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Keishi Hattori]

From Firebug documentation
console.groupCollapsed(object[, object, ...])
Like console.group(), but the block is initially collapsed.

[Jessie Berlin]

Created attachment 56512 [details]
Proposed patch to add console.groupCollapsed

[Pavel Feldman]

Comment on attachment 56512 [details]
Proposed patch to add console.groupCollapsed

Looks good. Thanks for putting it together!

[Jessie Berlin]

Comment on attachment 56512 [details]
Proposed patch to add console.groupCollapsed

Thanks for the review :)

Committed in r60234: http://trac.webkit.org/changeset/60234

[WebKit Review Bot]

http://trac.webkit.org/changeset/60234 might have broken Qt Linux Release

[Jessie Berlin]

(In reply to comment #4)
> http://trac.webkit.org/changeset/60234 might have broken Qt Linux Release

It doesn't appear that the Qt Linux Release is broken. There appear to be some compiler warnings that cropped up with this change (though they look unrelated, so I am not sure how that happened and would appreciate if someone could explain it to me), but they disappear after the 60235 revision.

[Timothy Hatcher]

The WebKit Review Bot always seems to bitch about the Qt bot for innocuous inspector changes. It is getting annoying…

[Eric Seidel (no email)]

We should change the name to SherriffBot, because that's what the WebKit Review Bot is.

He's bitching because the Qt bots keep losing their network conneciton mid-build and failing builds.  It's happening frequently for all builds.  We may just have to remove the Qt builders from the core set until they can get a stable network.

[Csaba Osztrogonác]

Many apologies for this false positive alarm.

It was a flakey test I skipped after this fail:
http://trac.webkit.org/changeset/60236

[Patrick Mueller]

I noticed that the MessageType enum in Console.h does not match  WebInspector.ConsoleMessage.MessageType in ConsoleView.js, and the mis-match seems to happen with this bug fix.  Are we still keeping these aligned?   It appears to me that we should be keeping them aligned.

Since I'm adding a new message type for Bug 38664, I thought I'd go ahead fix MessageType in ConsoleView.js in that patch.  

Since no one uses the Result MessageType from the C++ code, there's no problem with the current code, today, but it may cause problems down the road if we don't keep them aligned.