RESOLVED FIXED 31284
need to implement aria tree roles 
https://bugs.webkit.org/show_bug.cgi?id=31284
Summary need to implement aria tree roles
chris fleizach
Reported 2009-11-09 20:15:20 PST
we need tree, treegrid and treeitem
Attachments
patch (59.63 KB, patch)
2009-11-10 22:50 PST, chris fleizach 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2009-11-10 09:11:05 PST
treegrid is separate and will appear as a table, since its supposed to be more like a grid. this bug i will use just for tree treeitem
chris fleizach
Comment 2 2009-11-10 22:50:57 PST
Created attachment 42928 [details] patch Unfortunately getting an AXOutline to work on the mac is quite a bit of work, as it supports a lot of unique attributes and does some weird things with its children (as in, all rows are reported by the AXOutline regardless of level)
chris fleizach
Comment 3 2009-11-10 22:52:45 PST
i also had to fix some attributes in DRT that were returning JSValueNumber instead of JSValueBoolean, which meant fixing some LayoutTests.
Oliver Hunt
Comment 4 2009-11-11 12:32:37 PST
Comment on attachment 42928 [details] patch I suspect AccessibilityObject::ariaTreeRows can be made to crash if I make a sufficiently deep tree, i don't think we need to worry about this now, but it's worth considering. The change to AccessibilityRenderObject::accessibilityIsIgnored seems unnecessary, i say remove it :D
chris fleizach
Comment 5 2009-11-11 12:36:12 PST
thanx for the review. will commit tonight when i have time to monitor the submisson
chris fleizach
Comment 6 2009-11-11 21:26:49 PST
http://trac.webkit.org/changeset/50865
Note You need to log in before you can comment on or make changes to this bug.