Bug 31284 - need to implement aria tree roles
Summary: need to implement aria tree roles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-09 20:15 PST by chris fleizach
Modified: 2009-11-11 21:26 PST (History)
1 user (show)

See Also:


Attachments
patch (59.63 KB, patch)
2009-11-10 22:50 PST, chris fleizach
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-11-09 20:15:20 PST
we need tree, treegrid and treeitem
Comment 1 chris fleizach 2009-11-10 09:11:05 PST
treegrid is separate and will appear as a table, since its supposed to be more like a grid. 

this bug i will use just for

tree

treeitem
Comment 2 chris fleizach 2009-11-10 22:50:57 PST
Created attachment 42928 [details]
patch

Unfortunately getting an AXOutline to work on the mac is quite a bit of work, as it supports a lot of unique attributes and does some weird things with its children (as in, all rows are reported by the AXOutline regardless of level)
Comment 3 chris fleizach 2009-11-10 22:52:45 PST
i also had to fix some attributes in DRT that were returning JSValueNumber instead of JSValueBoolean, which meant fixing some LayoutTests.
Comment 4 Oliver Hunt 2009-11-11 12:32:37 PST
Comment on attachment 42928 [details]
patch

I suspect AccessibilityObject::ariaTreeRows can be made to crash if I make a sufficiently deep tree, i don't think we need to worry about this now, but it's worth considering.

The change to AccessibilityRenderObject::accessibilityIsIgnored seems unnecessary, i say remove it :D
Comment 5 chris fleizach 2009-11-11 12:36:12 PST
thanx for the review. will commit tonight when i have time to monitor the submisson
Comment 6 chris fleizach 2009-11-11 21:26:49 PST
http://trac.webkit.org/changeset/50865