Bug 31280 - svn-apply Perl error seen on commit-queue
Summary: svn-apply Perl error seen on commit-queue
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-09 17:20 PST by Eric Seidel (no email)
Modified: 2010-04-11 12:41 PDT (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-09 17:20:16 PST

(From update of attachment 42790 [details])
Rejecting patch 42790 from commit-queue.

Failed to run
'--reviewer', 'Kenneth Rohde Christiansen', '--force']" exit_code: 1
Last 500 characters of output:
.pm line 397, <> line 66.
Use of uninitialized value in subtraction (-) at
/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 397,
<> line 66.
Use of uninitialized value in subtraction (-) at
/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 398,
<> line 66.
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/WebCore.pro
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/WebCore.pro.rej

Comment 1 Joseph Pecoraro 2010-04-11 11:40:05 PDT
VCSUtils.pm has been edited multiple times since 2009-11-09. Cameron Zwarich gave me great advice the other day when I posted a bug on an ASSERT crash. He said you should also include the source line, in case files changes. That can save a lot of digging in the future.

I did the digging, and it looks like line 397 corresponded to line 396 in r50547, inside the fixChangeLogPatch function:

That has since moved to line 694!, has undergone some changes, and now includes unit tests!

Have you seen this problem crop up again recently or can this bug be closed?
Comment 2 Eric Seidel (no email) 2010-04-11 12:41:40 PDT
Yes, things are way better than when I filed this bug. :)