Bug 31280 – svn-apply Perl error seen on commit-queue

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Tools / Tests

[Eric Seidel (no email)]

https://bugs.webkit.org/show_bug.cgi?id=31273#c3

(From update of attachment 42790 [details])
Rejecting patch 42790 from commit-queue.

Failed to run
"['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply',
'--reviewer', 'Kenneth Rohde Christiansen', '--force']" exit_code: 1
Last 500 characters of output:
.pm line 397, <> line 66.
Use of uninitialized value in subtraction (-) at
/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 397,
<> line 66.
Use of uninitialized value in subtraction (-) at
/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 398,
<> line 66.
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/WebCore.pro
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/WebCore.pro.rej

Investigating.

[Joseph Pecoraro]

VCSUtils.pm has been edited multiple times since 2009-11-09. Cameron Zwarich gave me great advice the other day when I posted a bug on an ASSERT crash. He said you should also include the source line, in case files changes. That can save a lot of digging in the future.

I did the digging, and it looks like line 397 corresponded to line 396 in r50547, inside the fixChangeLogPatch function:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/VCSUtils.pm?rev=50547#L363

That has since moved to line 694!, has undergone some changes, and now includes unit tests!
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/VCSUtils.pm#L672

Have you seen this problem crop up again recently or can this bug be closed?

[Eric Seidel (no email)]

Yes, things are way better than when I filed this bug. :)