Bug 31275 - Fix Chromium's Posix VFS implementation by adding the required 'unused file descriptor' logic
Summary: Fix Chromium's Posix VFS implementation by adding the required 'unused file d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-09 14:53 PST by Dumitru Daniliuc
Modified: 2009-11-11 21:58 PST (History)
2 users (show)

See Also:


Attachments
patch (3.12 KB, patch)
2009-11-09 15:14 PST, Dumitru Daniliuc
no flags Details | Formatted Diff | Diff
patch (3.20 KB, patch)
2009-11-11 13:29 PST, Dumitru Daniliuc
dglazkov: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
patch (3.62 KB, patch)
2009-11-11 15:25 PST, Dumitru Daniliuc
dglazkov: review+
dumi: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2009-11-09 14:53:26 PST
The default SQLite VFS for Linux assumes that it might not always be able to close file descriptors. Therefore, it stores them in an "unused file descriptor" field of the sqlite3_file structure. That field is populated in the in xDlOpen() function. Ignoring that logic in Chromium's implementation resulted in a crash (dereferencing a NULL pointer). We need to fix that.
Comment 1 Dumitru Daniliuc 2009-11-09 15:14:31 PST
Created attachment 42809 [details]
patch

Please do not commit-queue+ this patch. I will manually commit it once the Chromium-side patch that it depends on is in.
Comment 2 Eric Seidel (no email) 2009-11-09 17:44:29 PST
Comment on attachment 42809 [details]
patch

No need to set cq? if you don't want it commit-queued. :)  You can also explicitly set cq-.
Comment 3 Dumitru Daniliuc 2009-11-11 13:29:05 PST
Created attachment 42995 [details]
patch

SQLite function names changed.
Comment 4 Dumitru Daniliuc 2009-11-11 15:25:49 PST
Created attachment 43011 [details]
patch

Function names changed once again.
Comment 5 Dimitri Glazkov (Google) 2009-11-11 21:48:19 PST
Comment on attachment 43011 [details]
patch

wow, shess is sure giving you hard time ;)
Comment 6 Dumitru Daniliuc 2009-11-11 21:58:49 PST
Landed as r50867.