Bug 31274 - Prepended $$PWD to GENERATED_SOURCES_DIR
Summary: Prepended $$PWD to GENERATED_SOURCES_DIR
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27065
  Show dependency treegraph
 
Reported: 2009-11-09 13:13 PST by Norbert Leser
Modified: 2010-02-22 15:27 PST (History)
6 users (show)

See Also:


Attachments
Patch for USERINCLUDE paths for symbian (1.20 KB, patch)
2009-11-09 13:13 PST, Norbert Leser
no flags Details | Formatted Diff | Diff
Patch for prepending PWD to GENERATED_SOURCES_DIR (1.20 KB, patch)
2009-11-09 13:16 PST, Norbert Leser
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Norbert Leser 2009-11-09 13:13:23 PST
Created attachment 42791 [details]
Patch for USERINCLUDE paths for symbian

Prepended $$PWD to GENERATED_SOURCES_DIR to avoid potential ambiguities when included from WebCore.pro.
Some preprocessors consider this GENERATED_SOURCES_DIR relative to current invoking dir (e.g., ./WebCore), and not the working dir of JavaCriptCore.pri (i.e., ../JavaScriptCore/).
Comment 1 Norbert Leser 2009-11-09 13:16:39 PST
Created attachment 42793 [details]
Patch for prepending PWD to GENERATED_SOURCES_DIR

Corrected description of previous patch.
Comment 2 WebKit Commit Bot 2009-11-09 14:35:06 PST
Comment on attachment 42793 [details]
Patch for prepending PWD to GENERATED_SOURCES_DIR

Clearing flags on attachment: 42793

Committed r50695: <http://trac.webkit.org/changeset/50695>
Comment 3 WebKit Commit Bot 2009-11-09 14:35:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Laszlo Gombos 2009-11-09 17:47:57 PST
Bug needs to be REOPENED as the landed fix had to be reverted because it broke clean build. Here is the error (breaks when it tries to compile standalone JSC).

../../../JavaScriptCore/pcre/pcre_tables.cpp:72:24: error: chartables.c: No such file or directory
make[1]: *** [obj/debug/pcre_tables.o] Error 1
make: *** [sub-JavaScriptCore-jsc-pro-make_default-ordered] Error 2

For some reason I can not change the status to REOPEN.
Comment 5 Eric Seidel (no email) 2009-11-09 17:51:59 PST
You look to have 3 separate bugzilla accounts. :(  I've added edit bugs permissions to a second one.
Comment 6 Eric Seidel (no email) 2009-11-09 17:52:46 PST
Starting a rollout per laszlo's request.
Comment 7 Eric Seidel (no email) 2009-11-09 17:55:15 PST
Nevermind.  Laszlo already rolled it out in r50701.  Please make sure you update the bug with the revision number if you do a rollout.
Comment 8 Norbert Leser 2009-11-09 17:57:19 PST
Sorry, to hear that it broke another build. Laszlo, can you specify what your build target was so I can try to reproduce it and work on a potential fix.
Comment 9 Laszlo Gombos 2009-11-09 18:36:41 PST
(In reply to comment #8)
> Sorry, to hear that it broke another build. Laszlo, can you specify what your
> build target was so I can try to reproduce it and work on a potential fix.

I saw the build break first on Mac (build-webkit --qt --no-svg --debug) and reproduced on Linux as well (build-webkit --qt --no--svg --release).

QtWebKit library builds Ok, but standalone jsc failed.
Comment 10 Laszlo Gombos 2010-02-22 15:27:07 PST
Does not seems to be an issue any more (especially after pre-generation step).