Bug 31269 - [Qt] Few classes have virtual functions but non-virtual destructor
Summary: [Qt] Few classes have virtual functions but non-virtual destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-11-09 12:51 PST by Laszlo Gombos
Modified: 2009-11-09 13:27 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (2.50 KB, patch)
2009-11-09 12:54 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-11-09 12:51:15 PST
QtWebKit builds with the following compiler warnings:

WebCore/platform/qt/QWebPageClient.h:31: warning: 'class QWebPageClient' has virtual functions but non-virtual destructor
WebKit/qt/Api/qgraphicswebview.cpp:37: warning: 'class QGraphicsWebViewPrivate' has virtual functions but non-virtual destructor

Patch will follow to address the warnings.
Comment 1 Kenneth Rohde Christiansen 2009-11-09 12:53:18 PST
Really good that you got the warnings turned on! Really good catching errors like these.
Comment 2 Laszlo Gombos 2009-11-09 12:54:54 PST
Created attachment 42786 [details]
proposed patch
Comment 3 WebKit Commit Bot 2009-11-09 13:27:16 PST
Comment on attachment 42786 [details]
proposed patch

Clearing flags on attachment: 42786

Committed r50684: <http://trac.webkit.org/changeset/50684>
Comment 4 WebKit Commit Bot 2009-11-09 13:27:22 PST
All reviewed patches have been landed.  Closing bug.