RESOLVED WONTFIX 31264
garbageCollectNow() should return a value 
https://bugs.webkit.org/show_bug.cgi?id=31264
Summary garbageCollectNow() should return a value
Yong Li
Reported 2009-11-09 11:10:38 PST
GCController::garbageCollectNow() should pass the return value of JS Heap::Collect() to the caller
Attachments
the patch (1.86 KB, patch)
2009-11-09 11:14 PST, Yong Li 		eric: review-
DetailsFormatted DiffDiff
Added more info in ChangeLog (1.95 KB, patch)
2009-12-23 08:02 PST, Yong Li 		sam: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2009-11-09 11:14:04 PST
Created attachment 42771 [details] the patch
Darin Adler
Comment 2 2009-11-09 16:44:13 PST
Comment on attachment 42771 [details] the patch Why?
Eric Seidel (no email)
Comment 3 2009-11-09 17:45:43 PST
Comment on attachment 42771 [details] the patch r-. ChangeLog needs "why" information.
Yong Li
Comment 4 2009-11-10 08:47:20 PST
(In reply to comment #2) > (From update of attachment 42771 [details]) > Why? The caller can use the return value to know if it's necessary to call it again. Sometimes calling it only once doesn't clean up everything it can, because a JS object may be referenced by another. With this return value, before a thread is going to sleep, it can try to clean up JS garbage as much as possible. And this return value doesn't hurt anyone who doesn't need it. Consider why JSC::Heap::collect returns a boolean.
Yong Li
Comment 5 2009-12-23 08:02:53 PST
Created attachment 45440 [details] Added more info in ChangeLog
Sam Weinig
Comment 6 2009-12-23 11:15:20 PST
Comment on attachment 45440 [details] Added more info in ChangeLog This patch will not compile, as the JSC garbage collector Heap no longer has a method called collect(). It has been replaced by a method called collectAllGarbage() which does not return a value. This bug should probably be closed.
Alexey Proskuryakov
Comment 7 2010-06-12 16:14:36 PDT
Closing per the above comment. Please feel free to re-open if you disagree.
Note You need to log in before you can comment on or make changes to this bug.