Bug 312599 – [GTK] [2.53.1] Fails to build on i386: "libpas, mimalloc, or system malloc needs to be specified"

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alberto Garcia]

What the title says.

I wonder if we should do something like this:

--- a/Source/cmake/WebKitFeatures.cmake
+++ b/Source/cmake/WebKitFeatures.cmake
@@ -120,7 +120,7 @@ macro(WEBKIT_OPTION_BEGIN)
     else ()
         set(ENABLE_JIT_DEFAULT OFF)
         set(ENABLE_FTL_DEFAULT OFF)
-        set(USE_SYSTEM_MALLOC_DEFAULT OFF)
+        set(USE_SYSTEM_MALLOC_DEFAULT ON)
         set(USE_MIMALLOC_DEFAULT OFF)
         set(ENABLE_C_LOOP_DEFAULT ON)
         set(ENABLE_SAMPLING_PROFILER_DEFAULT OFF)

Or fix the check in bmalloc/BPlatform.h:

#if defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
#define BUSE_SYSTEM_MALLOC 1
#else
#if BOS(DARWIN) && !BCPU(ADDRESS64)
#define BUSE_SYSTEM_MALLOC 1
#else
#define BUSE_SYSTEM_MALLOC 0
#endif
#endif

[Michael Catanzaro]

Uh, does bmalloc not support ix86 anymore?

[Alberto Garcia]

I think that commit https://commits.webkit.org/305908@main changed that default in the else() branch of WebKitFeatures.cmake

[Alberto Garcia]

Pull request: https://github.com/WebKit/WebKit/pull/63005

[EWS]

Committed 311494@main (def81584975d): <https://commits.webkit.org/311494@main>

Reviewed commits have been landed. Closing PR #63005 and removing active labels.