Bug 31244 - [GTK] Remove WebSocket configuration from WebKitWebSettings
Summary: [GTK] Remove WebSocket configuration from WebKitWebSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-08 18:01 PST by Martin Robinson
Modified: 2009-11-10 03:42 PST (History)
4 users (show)

See Also:


Attachments
Patch for this issue (4.46 KB, patch)
2009-11-08 18:03 PST, Martin Robinson
jmalonzo: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for this issue (against ToT) (4.61 KB, patch)
2009-11-09 19:16 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Follow-up patch for DRT (1.73 KB, patch)
2009-11-10 03:09 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2009-11-08 18:01:21 PST
Bug 29896 disabled runtime configuration of WebSockets for all non-Chromium/V8 ports. We need to remove the now non-functional enable-web-sockets property from WebKitWebSettings.
Comment 1 Martin Robinson 2009-11-08 18:03:03 PST
Created attachment 42724 [details]
Patch for this issue

I've attached a patch removing this property.
Comment 2 Jan Alonzo 2009-11-09 01:13:35 PST
Comment on attachment 42724 [details]
Patch for this issue

r=me. Thanks for the cleanup.
Comment 3 WebKit Commit Bot 2009-11-09 01:17:11 PST
Comment on attachment 42724 [details]
Patch for this issue

Rejecting patch 42724 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Jan Alonzo', '--force']" exit_code: 1
Last 500 characters of output:
---------------------------------------------
patching file WebKit/gtk/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/gtk/webkit/webkitwebsettings.cpp
Hunk #1 succeeded at 96 with fuzz 2.
Hunk #2 FAILED at 137.
Hunk #3 succeeded at 652 (offset 2 lines).
Hunk #4 succeeded at 879 (offset 21 lines).
Hunk #5 succeeded at 996 (offset 24 lines).
Hunk #6 succeeded at 1066 (offset 27 lines).
1 out of 6 hunks FAILED -- saving rejects to file WebKit/gtk/webkit/webkitwebsettings.cpp.rej
Comment 4 Eric Seidel (no email) 2009-11-09 16:59:43 PST
Looks like the patch just rotted a little.  It will need to be updated by the author or someone can attempt to manually apply it.
Comment 5 Martin Robinson 2009-11-09 19:16:50 PST
Created attachment 42841 [details]
Patch for this issue (against ToT)

I've attached an updated patch against ToT.
Comment 6 WebKit Commit Bot 2009-11-10 01:15:38 PST
Comment on attachment 42841 [details]
Patch for this issue (against ToT)

Clearing flags on attachment: 42841

Committed r50724: <http://trac.webkit.org/changeset/50724>
Comment 7 WebKit Commit Bot 2009-11-10 01:15:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Philippe Normand 2009-11-10 03:03:39 PST
DRT still sets that non-existing property and issues a warning
Comment 9 Gustavo Noronha (kov) 2009-11-10 03:06:05 PST
One more place needs to be cleaned up, it seems.
Comment 10 Philippe Normand 2009-11-10 03:09:53 PST
Created attachment 42856 [details]
Follow-up patch for DRT
Comment 11 Jan Alonzo 2009-11-10 03:15:11 PST
Comment on attachment 42856 [details]
Follow-up patch for DRT

r=me.
Comment 12 WebKit Commit Bot 2009-11-10 03:42:42 PST
Comment on attachment 42856 [details]
Follow-up patch for DRT

Clearing flags on attachment: 42856

Committed r50737: <http://trac.webkit.org/changeset/50737>
Comment 13 WebKit Commit Bot 2009-11-10 03:42:47 PST
All reviewed patches have been landed.  Closing bug.