Bug 31226 - V8 WorkerContextExecutionProxy does not handle SharedWorkers
Summary: V8 WorkerContextExecutionProxy does not handle SharedWorkers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-07 10:06 PST by Andrew Wilson
Modified: 2009-11-08 22:00 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (4.03 KB, patch)
2009-11-07 10:12 PST, Andrew Wilson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-11-07 10:06:28 PST
WorkerContextExecutionProxy does not currently handle SharedWorkers:

* It always creates a DedicatedWorkerContext for the global context
* It does not know how to convert an EventTarget to a SharedWorker or SharedWorkerContext
Comment 1 Andrew Wilson 2009-11-07 10:12:57 PST
Created attachment 42697 [details]
proposed patch
Comment 2 Andrew Wilson 2009-11-07 10:13:41 PST
Adding dglazkov in case he has a chance to review this.
Comment 3 Dimitri Glazkov (Google) 2009-11-08 21:43:29 PST
Comment on attachment 42697 [details]
proposed patch

r=me.
Comment 4 WebKit Commit Bot 2009-11-08 22:00:10 PST
Comment on attachment 42697 [details]
proposed patch

Clearing flags on attachment: 42697

Committed r50638: <http://trac.webkit.org/changeset/50638>
Comment 5 WebKit Commit Bot 2009-11-08 22:00:14 PST
All reviewed patches have been landed.  Closing bug.