RESOLVED INVALID31214
check-webkit-style needs to be taught about "WebCommon.h" 
https://bugs.webkit.org/show_bug.cgi?id=31214
Summary check-webkit-style needs to be taught about "WebCommon.h"
Eric Seidel (no email)
Reported 2009-11-06 14:58:53 PST
check-webkit-style needs to be taught about "WebCommon.h" The Chromium WebKit API layer uses a "WebCommon.h" instead of a config.h. check-webkit-style doesn't know about this special header and flags it as unsorted.
Attachments
Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-11-06 15:42:46 PST
I did a quick look at a few files. It doesn't take the place of config.h which is for cpp files. It seems only to be used in a few .h files and there doesn't seem to be a down side to sorting it like any other file.
Eric Seidel (no email)
Comment 2 2009-11-06 15:44:22 PST
OK, then I'll fix the sorting in the few files and we can close this.
Dimitri Glazkov (Google)
Comment 3 2009-11-06 16:11:32 PST
I disagree. I would like to keep WebCommon.h at the top.
Martin Robinson
Comment 4 2021-02-05 01:02:38 PST
Chromium is no longer part of the tree and there are no remaining references to WebCommon.h.
Note You need to log in before you can comment on or make changes to this bug.