Bug 31209 - V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include
Summary: V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-06 10:58 PST by Steve Block
Modified: 2009-11-06 12:01 PST (History)
4 users (show)

See Also:

Attachments
Patch 1 for Bug 31209 (1.16 KB, patch)
2009-11-06 11:05 PST, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-11-06 10:58:43 PST 
V8DOMWindowCustom.cpp is missing WEB_SOCKETS feature guard on include of WebSockets.h. All other include sites of WebSockets.h from outside of websockets code use this guard.
Comment 1 Steve Block 2009-11-06 11:05:25 PST 
Created attachment 42660 [details]
Patch 1 for Bug 31209
Comment 2 Eric Seidel (no email) 2009-11-06 11:23:33 PST 
Comment on attachment 42660 [details]
Patch 1 for Bug 31209

LGTM.
Comment 3 Eric Seidel (no email) 2009-11-06 11:23:57 PST 
Comment on attachment 42660 [details]
Patch 1 for Bug 31209

Build fixes don't require review, but review is always nice for any patch. :)
Comment 4 WebKit Commit Bot 2009-11-06 11:38:35 PST 
Comment on attachment 42660 [details]
Patch 1 for Bug 31209

Rejecting patch 42660 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11573 test cases.
transitions/transition-end-event-transform.html -> failed

Exiting early after 1 failures. 11507 tests run.
484.99s total testing time

11506 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output
Comment 5 Eric Seidel (no email) 2009-11-06 11:43:31 PST 
Comment on attachment 42660 [details]
Patch 1 for Bug 31209

Must be a flakey test.  I'll file a bug.
Comment 6 Eric Seidel (no email) 2009-11-06 11:44:49 PST 
Turns out this was a known issue.  Updated bug 30029.
Comment 7 WebKit Commit Bot 2009-11-06 12:01:24 PST 
Comment on attachment 42660 [details]
Patch 1 for Bug 31209

Clearing flags on attachment: 42660

Committed r50603: <http://trac.webkit.org/changeset/50603>
Comment 8 WebKit Commit Bot 2009-11-06 12:01:28 PST 
All reviewed patches have been landed.  Closing bug.