Bug 31209 – V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Steve Block]

V8DOMWindowCustom.cpp is missing WEB_SOCKETS feature guard on include of WebSockets.h. All other include sites of WebSockets.h from outside of websockets code use this guard.

[Steve Block]

Created attachment 42660 [details]
Patch 1 for Bug 31209

[Eric Seidel (no email)]

Comment on attachment 42660 [details]
Patch 1 for Bug 31209

LGTM.

[Eric Seidel (no email)]

Comment on attachment 42660 [details]
Patch 1 for Bug 31209

Build fixes don't require review, but review is always nice for any patch. :)

[WebKit Commit Bot]

Comment on attachment 42660 [details]
Patch 1 for Bug 31209

Rejecting patch 42660 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11573 test cases.
transitions/transition-end-event-transform.html -> failed

Exiting early after 1 failures. 11507 tests run.
484.99s total testing time

11506 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output

[Eric Seidel (no email)]

Comment on attachment 42660 [details]
Patch 1 for Bug 31209

Must be a flakey test.  I'll file a bug.

[Eric Seidel (no email)]

Turns out this was a known issue.  Updated bug 30029.

[WebKit Commit Bot]

Comment on attachment 42660 [details]
Patch 1 for Bug 31209

Clearing flags on attachment: 42660

Committed r50603: <http://trac.webkit.org/changeset/50603>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.