Bug 31208 – [Qt] Pass credentials provided by XMLHTTPRequest to the network request.

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Yael]

When XMLHTTPRequest gets credentials in the open() method, they should be passed to the network request.

[Yael]

Created attachment 42659 [details]
Patch

Follow other ports and re-attach the credentials to the request URL.

[Holger Freyther]

Comment on attachment 42659 [details]
Patch

Sorry specially as this is a regression we will need a test case for this... I don't want to see it failing again.

[Yael]

(In reply to comment #2)
> (From update of attachment 42659 [details])
> Sorry specially as this is a regression we will need a test case for this... I
> don't want to see it failing again.

Test cases are already in place for this. Please take a look at LayOutTests/http/xmlhttprequest/basic-auth.html.

Running this test, I found out that my patch fixes only async XHR, so I will submit a new patch soon, that will take care of sync XHR as well.

[Kenneth Rohde Christiansen]

Patch looks good, but should this:

// so that they can be passed to QNetworkRequest.

be

// so that they will be passed to QNetworkRequest.

?

[Yael]

Created attachment 42752 [details]
Patch

Fix authentication for sync XHR too. Also changed the comment as requested in comment #4, and added comment that LayOutTests/http/xmlhttprequest/basic-auth.html now passes.

[WebKit Commit Bot]

Comment on attachment 42752 [details]
Patch

Rejecting patch 42752 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

[Kenneth Rohde Christiansen]

Trying again after:

Changeset [50660]  by [e-mail]

    Adding Kenneth to the reviewers list.

    * Scripts/modules/committers.py:

[WebKit Commit Bot]

Comment on attachment 42752 [details]
Patch

Rejecting patch 42752 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

[Yael]

(In reply to comment #8)
> (From update of attachment 42752 [details])
> Rejecting patch 42752 from review queue.
> 
> [e-mail] does not have reviewer permissions according to
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

Congratulations Kenneth!
I think it takes a few days before a new reviewer can approve patches.

[Kenneth Rohde Christiansen]

(In reply to comment #9)
> (In reply to comment #8)
> > (From update of attachment 42752 [details] [details])
> > Rejecting patch 42752 from review queue.
> > 
> > [e-mail] does not have reviewer permissions according to
> > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
> 
> Congratulations Kenneth!
> I think it takes a few days before a new reviewer can approve patches.

Thanks. But it is the script that checks against that file, so maybe the commit bot doesn't check again the newest version or something else is wrong. I'm trying to talk to Eric on irc.

[Eric Seidel (no email)]

Yes, sorry.  Due to bug 30084 the commit-queue requires a restart to pick up committers.py modifications.  I've restarted the queue now.

[Kenneth Rohde Christiansen]

Landed in 50662.

[Kenneth Rohde Christiansen]

OK, thanks Eric! :-) I committed one minute, before you restarted it. So I hope I was fast enough to clear the cq field.

[Eric Seidel (no email)]

You can always see what the commit-queue is currently working on via:
http://webkit-commit-queue.appspot.com/

Basically you can always outrun the commit-queue.  Its commit will fail if you manage to commit before it.