Bug 311995 – [GTK] evolution-3.58.3 crashes with webkit-gtk-2.52.1

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Sam James]

Created attachment 479010 [details]
email-with-attachment-crash.txt

Forwarding a downstream bug from https://bugs.gentoo.org/972453.

Attached two backtraces:
1) when attempting to view an email with an attachment;
2) trying to reply to a HTML email.

[Sam James]

Created attachment 479011 [details]
reply-to-html-email-crash.txt

Created attachment 479123 [details]
Same crash traceback net-libs/webkit-gtk-2.52.2-r410 and mail-client/evolution-3.60.1

I'm the one affected by the linked gentoo bug.

While a suggestion was that this could have been https://bugs.webkit.org/show_bug.cgi?id=310662, the same crash occurs with webkit-gtk-2.52.2 (and more current evolution-3.60.1).

Further testing showed that this occurs only when trying to reply to E-Mails encoded with "Content-Transfer-Encoding: quoted-printable" and not with base64 encoding.

I suspect that the crashing /usr/libexec/webkit2gtk-4.1/WebKitWebProcess is responsible for the decoding, so there could be some problem with decoding quoted-printable, with charset="iso-8859-1", in a utf8 environment (with libicu-78.3).

Any suggestions for further testing? Thanks!

[Milan Crha]

Created attachment 479650 [details]
proposed patch

See the commit message for explanation.

It was confirmed at https://gitlab.gnome.org/GNOME/evolution/-/work_items/3298#note_2760363 that the patch works. You can give it more time for testing, if you wish, as I guess Bernd will give it a try as well.

Sorry for the delay - I was traveling.
I have now put net-libs/webkit-gtk-2.52.3-r410 with this patch through some stress testing with replies to mixed HTML mails as well as showing calendar invitations that crashed before, and there were no segfaults any more.
Thanks a lot!

[Michael Catanzaro]

Comment on attachment 479650 [details]
proposed patch

This change is correct. It's indeed a common mistake in WebKit. Thanks.

[Michael Catanzaro]

P.S. It's better to submit pull requests on GitHub, but I think commit-queue still works here? We are about to find out.

[EWS]

Committed 313602@main (cc28449d96ca): <https://commits.webkit.org/313602@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 479650 [details].

[Michael Catanzaro]

I went to backport this to stable branch, and discovered Adrian was paying attention and beat me to it. Thank you. https://commits.webkit.org/305877.622@webkitglib/2.52 (the URLs don't work currently, but maybe they will eventually)

[Milan Crha]

I've a read-only GutHub checkout, not a fork. Passing patches is simpler for me. As it worked the last time, few weeks ago, it worked here too ;) I hope it'll stay alive for longer time, but if not, I'll just figure out a new workflow with the patches (my lazy side uses things its used to instead of learning new things).