Bug 31199 - V8 bindings do not support SharedWorkers as event targets
Summary: V8 bindings do not support SharedWorkers as event targets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-05 22:51 PST by Andrew Wilson
Modified: 2009-11-06 08:18 PST (History)
1 user (show)

See Also:

Attachments
proposed patch (1.40 KB, patch)
2009-11-05 22:55 PST, Andrew Wilson 		no flags Details | Formatted Diff | Diff
fixed bug (was passing "null" as the target) (1.41 KB, patch)
2009-11-05 22:58 PST, Andrew Wilson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-11-05 22:51:04 PST 
V8DOMWrapper::convertEventTargetToV8Object() doesn't handle SharedWorkers currently, so we get a failed assertion if you ever try to send an event to a shared worker.
Comment 1 Andrew Wilson 2009-11-05 22:55:56 PST 
Created attachment 42631 [details]
proposed patch
Comment 2 Andrew Wilson 2009-11-05 22:58:46 PST 
Created attachment 42632 [details]
fixed bug (was passing "null" as the target)
Comment 3 WebKit Commit Bot 2009-11-06 08:18:50 PST 
Comment on attachment 42632 [details]
fixed bug (was passing "null" as the target)

Clearing flags on attachment: 42632

Committed r50600: <http://trac.webkit.org/changeset/50600>
Comment 4 WebKit Commit Bot 2009-11-06 08:18:54 PST 
All reviewed patches have been landed.  Closing bug.