Bug 31197 - Implemented a timezone cache not based on Mac OS X's notify_check API
: Implemented a timezone cache not based on Mac OS X's notify_check API
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Geoffrey Garen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-05 22:17 PST by Geoffrey Garen
Modified: 2009-11-09 17:27 PST (History)
2 users (show)

See Also:


Attachments
patch (26.19 KB, patch)
2009-11-05 22:17 PST, Geoffrey Garen
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2009-11-05 22:17:05 PST
Created attachment 42629 [details]
patch

Patch coming.
Comment 1 Geoffrey Garen 2009-11-05 22:27:50 PST
*** Bug 15853 has been marked as a duplicate of this bug. ***
Comment 2 Geoffrey Garen 2009-11-05 22:54:14 PST
Still working out some Windows build issues...
Comment 3 Eric Seidel 2009-11-05 23:04:00 PST
So in a long-running gmail instance we no longer would notice daylight savings time changes, correct?
Comment 4 Darin Adler 2009-11-06 08:22:32 PST
(In reply to comment #3)
> So in a long-running gmail instance we no longer would notice daylight savings
> time changes, correct?

If the entire long-running gmail "instance" is a single JavaScript function that never returns, then you're correct. But I don't know of anything like that.
Comment 5 Eric Seidel 2009-11-06 09:00:46 PST
Ah. I incorrectly read "VM invocation" as "VM instance" and assumed there was one per page.  Thank you for the clarification.
Comment 6 Geoffrey Garen 2009-11-06 11:53:15 PST
(In reply to comment #3)
> So in a long-running gmail instance we no longer would notice daylight savings
> time changes, correct?

(Minor correction: this patch is about timezone, not daylight savings time.)

Note that, in v8, in a long-runing gmail instance you will indeed not notice timezone changes. Part of the design of this patch is to enable the VM to notice timezone changes in a not-too-surprising way, given that other VMs don't notice them at all.
Comment 7 Eric Seidel 2009-11-06 12:19:45 PST
(In reply to comment #6)
> (In reply to comment #3)
> > So in a long-running gmail instance we no longer would notice daylight savings
> > time changes, correct?
> 
> (Minor correction: this patch is about timezone, not daylight savings time.)
> 
> Note that, in v8, in a long-runing gmail instance you will indeed not notice
> timezone changes. Part of the design of this patch is to enable the VM to
> notice timezone changes in a not-too-surprising way, given that other VMs don't
> notice them at all.

Thank you for the clarifications.
Comment 8 Eric Seidel 2009-11-09 17:27:57 PST
Was landed as r50590.