RESOLVED FIXED311960
[libpas] De-singletonize pas_large_map to allow for multiple instances
https://bugs.webkit.org/show_bug.cgi?id=311960
Summary [libpas] De-singletonize pas_large_map to allow for multiple instances
Marcus Plutowski
Reported 2026-04-10 12:26:25 PDT
rdar://174512866 Currently, libpas uses singletons for the various large-map hashtables (and associated metadata): ``` PAS_API extern pas_large_map_hashtable pas_large_map_hashtable_instance; PAS_API extern pas_large_map_hashtable_in_flux_stash pas_large_map_hashtable_instance_in_flux_stash; PAS_API extern pas_small_large_map_hashtable pas_small_large_map_hashtable_instance; PAS_API extern pas_small_large_map_hashtable_in_flux_stash pas_small_large_map_hashtable_instance_in_flux_stash; PAS_API extern pas_tiny_large_map_hashtable pas_tiny_large_map_hashtable_instance; PAS_API extern pas_tiny_large_map_hashtable_in_flux_stash pas_tiny_large_map_hashtable_instance_in_flux_stash; PAS_API extern pas_tiny_large_map_second_level_hashtable_in_flux_stash pas_tiny_large_map_second_level_hashtable_in_flux_stash_instance; ``` This is unnecessary, and should be changed to help clear the way for future projects. In particular, we should be able to instantiate an arbitrary number of large-map instances (for each of the above types), and associate each large-heap with an arbitrary large map.
Attachments
Marcus Plutowski
Comment 1 2026-04-10 12:34:04 PDT
EWS
Comment 2 2026-04-15 14:13:13 PDT
Committed 311318@main (2c7b7e22dca5): <https://commits.webkit.org/311318@main> Reviewed commits have been landed. Closing PR #62476 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.