Bug 31191 - [v8] get rid of unnecessary synchronization in weak reference callbacks
: [v8] get rid of unnecessary synchronization in weak reference callbacks
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-11-05 15:23 PST by
Modified: 2009-11-06 05:49 PST (History)


Attachments
First take (2.22 KB, patch)
2009-11-05 15:27 PST, anton muhin
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-11-05 15:23:41 PST
Currently browser and renderer execute V8-related code (including GC) in the main thread.  So a lot of synchronization is actually unused and only makes us slower.

I don't do the full cleanup (but would do on request) to make it easier to rollback this synchronization infrastructure if need be.  On the other side that's exactly what version control should do.
------- Comment #1 From 2009-11-05 15:27:00 PST -------
Created an attachment (id=42604) [details]
First take
------- Comment #2 From 2009-11-05 20:19:02 PST -------
(From update of attachment 42604 [details])
Ok.  Isn't our plan to run workers in process at some point?  I guess we can tackle that problem when we come to it.
------- Comment #3 From 2009-11-06 05:30:04 PST -------
(In reply to comment #2)
> (From update of attachment 42604 [details] [details])
> Ok.  Isn't our plan to run workers in process at some point?  I guess we can
> tackle that problem when we come to it.

Yep.  That's exactly why I don't want to cleanup the stuff.
------- Comment #4 From 2009-11-06 05:30:29 PST -------
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 42604 [details] [details] [details])
> > Ok.  Isn't our plan to run workers in process at some point?  I guess we can
> > tackle that problem when we come to it.
> 
> Yep.  That's exactly why I don't want to cleanup the stuff.

And thanks a lot for review.
------- Comment #5 From 2009-11-06 05:49:13 PST -------
(From update of attachment 42604 [details])
Clearing flags on attachment: 42604

Committed r50598: <http://trac.webkit.org/changeset/50598>
------- Comment #6 From 2009-11-06 05:49:19 PST -------
All reviewed patches have been landed.  Closing bug.