- Introduce utility scripts for code reuse - Migrate from div section for frontend scripts to function prefix - Rename evaluate-in-frontend.js to inspector-test.js - Rename highlighters tests - Other cleanups
Created attachment 42600 [details] [PATCH]
Comment on attachment 42600 [details] [PATCH] > + for (var i = 0; i < result.length; ++i) { > + output(result[i].text + " " + result[i].clazz); > + } No braces. > - var output = document.getElementById("output"); > + var output = document.getElementById("outputPre"); I don't think Pre helps. What was wrong with output? > +window.didEvaluateForTestInFrontend = function(callId, jsonResult) This should just be function didEvaluateForTestInFrontend(callId, jsonResult) > +//Fronten functions. Typo. Needs space after //. > +// Fronten functions. Typo.
(In reply to comment #2) > (From update of attachment 42600 [details]) > > > + for (var i = 0; i < result.length; ++i) { > > + output(result[i].text + " " + result[i].clazz); > > + } > > No braces. > > > > - var output = document.getElementById("output"); > > + var output = document.getElementById("outputPre"); > > I don't think Pre helps. What was wrong with output? > Otherwise it gives single line output... > > > +window.didEvaluateForTestInFrontend = function(callId, jsonResult) > > This should just be function didEvaluateForTestInFrontend(callId, jsonResult) > Done. > > > +//Fronten functions. > > Typo. Needs space after //. > Done. > > > +// Fronten functions. > > Typo. Done. Copy paste / regex issue.
Committing to http://svn.webkit.org/repository/webkit/trunk ... R LayoutTests/inspector/evaluate-in-frontend.js => LayoutTests/inspector/inspector-test.js R LayoutTests/inspector/css-syntax-highlight-expected.txt => LayoutTests/inspector/syntax-highlight-css-expected.txt R LayoutTests/inspector/javascript-syntax-highlight-expected.txt => LayoutTests/inspector/syntax-highlight-javascript-expected.txt D LayoutTests/inspector/css-syntax-highlight.html D LayoutTests/inspector/javascript-syntax-highlight.html M LayoutTests/ChangeLog M LayoutTests/inspector/console-dir-expected.txt M LayoutTests/inspector/console-dir.html M LayoutTests/inspector/console-dirxml-expected.txt M LayoutTests/inspector/console-dirxml.html M LayoutTests/inspector/console-format-collections-expected.txt M LayoutTests/inspector/console-format-collections.html M LayoutTests/inspector/console-format-expected.txt M LayoutTests/inspector/console-format.html M LayoutTests/inspector/console-tests-expected.txt M LayoutTests/inspector/console-tests.html A LayoutTests/inspector/console-tests.js M LayoutTests/inspector/elements-panel-structure-expected.txt M LayoutTests/inspector/elements-panel-structure.html A LayoutTests/inspector/elements-tests.js M LayoutTests/inspector/evaluate-in-frontend.html M LayoutTests/inspector/styles-iframe.html A LayoutTests/inspector/syntax-highlight-css.html A LayoutTests/inspector/syntax-highlight-javascript.html A LayoutTests/inspector/syntax-highlight.js M LayoutTests/inspector/timeline-trivial.html M LayoutTests/platform/qt/Skipped Committed r50582