WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
311853
[GFC][Cleanup] Change ADD_REASON_AND_RETURN_IF_NEEDED to accept GridAvoidanceReason values directly
https://bugs.webkit.org/show_bug.cgi?id=311853
Summary
[GFC][Cleanup] Change ADD_REASON_AND_RETURN_IF_NEEDED to accept GridAvoidance...
Sammy Gill
Reported
2026-04-09 14:15:17 PDT
Right now the macro accepts and uses the values of the enum in the definition (i.e. it prepends GridAvoidanceReason to the token when using it). This prevents us from passing in and using an lvalue that we have.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2026-04-09 14:15:26 PDT
<
rdar://problem/174438472
>
Sammy Gill
Comment 2
2026-04-09 14:30:52 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/62386
EWS
Comment 3
2026-04-09 20:44:10 PDT
Committed
310896@main
(3b5e0fe59a00): <
https://commits.webkit.org/310896@main
> Reviewed commits have been landed. Closing PR #62386 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug