Build bot reports failure on the above test case: http://build.webkit.org/results/Qt%20Linux%20Release/r50408%20%283364%29/results.html
Created attachment 42592 [details] fix patch
Comment on attachment 42592 [details] fix patch This change should really have a code comment to explain what 8 and 127 are. Using nicely named constants would be even better.
Created attachment 42649 [details] update after Eric's comment
Comment on attachment 42649 [details] update after Eric's comment We generally use static variables instead of #defines, but we can always change that later. cq+
Comment on attachment 42649 [details] update after Eric's comment Clearing flags on attachment: 42649 Committed r50624: <http://trac.webkit.org/changeset/50624>
All reviewed patches have been landed. Closing bug.
(In reply to comment #4) > (From update of attachment 42649 [details]) > We generally use static variables instead of #defines, but we can always change > that later. cq+ Will keep that in mind.