Bug 31185 - [Qt] Layout Test editing/undo/undo-deleteWord.html fails
Summary: [Qt] Layout Test editing/undo/undo-deleteWord.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-05 13:36 PST by Chang Shu
Modified: 2009-11-09 06:21 PST (History)
2 users (show)

See Also:


Attachments
fix patch (1.35 KB, patch)
2009-11-05 13:44 PST, Chang Shu
no flags Details | Formatted Diff | Diff
update after Eric's comment (2.99 KB, patch)
2009-11-06 06:32 PST, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2009-11-05 13:36:51 PST
Build bot reports failure on the above test case:
http://build.webkit.org/results/Qt%20Linux%20Release/r50408%20%283364%29/results.html
Comment 1 Chang Shu 2009-11-05 13:44:12 PST
Created attachment 42592 [details]
fix patch
Comment 2 Eric Seidel (no email) 2009-11-05 15:21:10 PST
Comment on attachment 42592 [details]
fix patch

This change should really have a code comment to explain what 8 and 127 are.  Using nicely named constants would be even better.
Comment 3 Chang Shu 2009-11-06 06:32:00 PST
Created attachment 42649 [details]
update after Eric's comment
Comment 4 Eric Seidel (no email) 2009-11-08 10:36:09 PST
Comment on attachment 42649 [details]
update after Eric's comment

We generally use static variables instead of #defines, but we can always change that later.  cq+
Comment 5 WebKit Commit Bot 2009-11-08 10:51:33 PST
Comment on attachment 42649 [details]
update after Eric's comment

Clearing flags on attachment: 42649

Committed r50624: <http://trac.webkit.org/changeset/50624>
Comment 6 WebKit Commit Bot 2009-11-08 10:51:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Chang Shu 2009-11-09 06:21:30 PST
(In reply to comment #4)
> (From update of attachment 42649 [details])
> We generally use static variables instead of #defines, but we can always change
> that later.  cq+

Will keep that in mind.