Bug 31179 - SVG Status page update
: SVG Status page update
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Website
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
http://webkit.org/projects/svg/status...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-05 11:06 PST by Jeff Schiller
Modified: 2009-11-06 10:32 PST (History)
2 users (show)

See Also:


Attachments
Patch updates the SVG status page and includes proper Bugzilla URL (4.88 KB, patch)
2009-11-05 11:10 PST, Jeff Schiller
no flags Details | Formatted Diff | Diff
Patch updated to include SVG Filter status from krit (5.74 KB, patch)
2009-11-05 12:43 PST, Jeff Schiller
eric: review+
commit-queue: commit‑queue-
Details | Formatted Diff | Diff
Patch without tabs in it. (5.74 KB, patch)
2009-11-05 17:31 PST, Jeff Schiller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Schiller 2009-11-05 11:06:49 PST
* Missing a proper Bug List URL.
* Bugs 5527,5970,5973,5976,6719 have been resolved for Filters
* Add some new Filter bugs
Comment 1 Jeff Schiller 2009-11-05 11:10:16 PST
Created attachment 42580 [details]
Patch updates the SVG status page and includes proper Bugzilla URL

I think Dirk should review the Filters section.
Comment 2 Dirk Schulze 2009-11-05 12:16:29 PST
Hm. We should be fair and update the status of some filters to Unimplemented: feDisplacementMap, feImage, feDiffuseLightning, feSpecularLigthning, feDistantLight, fePointLight, feSpotLight. It's maybe usefull to mention that it's neccessary to enable filters :-).
Comment 3 Jeff Schiller 2009-11-05 12:28:37 PST
Ok, I can do that.  Unimplemented or partial?

I guess there are no open bugs for those yet?

Also, what is the status of feGaussianBlur?  I have 'partial' at the moment.
Comment 4 Dirk Schulze 2009-11-05 12:34:31 PST
(In reply to comment #3)
> Ok, I can do that.  Unimplemented or partial?
Unimplemented, we don't have support for them.

> Also, what is the status of feGaussianBlur?  I have 'partial' at the moment.
I hope that we have a complete implementation :-)
Comment 5 Jeff Schiller 2009-11-05 12:43:37 PST
Created attachment 42587 [details]
Patch updated to include SVG Filter status from krit
Comment 6 Eric Seidel 2009-11-05 15:24:51 PST
Comment on attachment 42587 [details]
Patch updated to include SVG Filter status from krit

OK.  I bet there are more updates needed too.  But this looks fine.  Adding cq+ since you're not a committer to my knowledge.
Comment 7 WebKit Commit Bot 2009-11-05 15:40:14 PST
Comment on attachment 42587 [details]
Patch updated to include SVG Filter status from krit

Rejecting patch 42587 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
/webkit/trunk ...
	M	WebKitSite/ChangeLog
	M	WebKitSite/projects/svg/status.xml
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/WebKitSite/projects/svg/status.xml

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/libexec/git-core//git-svn line 469
Comment 8 Jeff Schiller 2009-11-05 17:31:37 PST
Created attachment 42612 [details]
Patch without tabs in it.

Sigh.

I hope this works, I used 'detab' in TextWrangler (though I did see a WebKitTools/Scripts/wkstyle)

Eric is correct, I do not have commit access so please commit-queue+
Comment 9 WebKit Commit Bot 2009-11-06 10:32:27 PST
Comment on attachment 42612 [details]
Patch without tabs in it.

Clearing flags on attachment: 42612

Committed r50601: <http://trac.webkit.org/changeset/50601>
Comment 10 WebKit Commit Bot 2009-11-06 10:32:32 PST
All reviewed patches have been landed.  Closing bug.