RESOLVED FIXED31179
SVG Status page update
https://bugs.webkit.org/show_bug.cgi?id=31179
Summary SVG Status page update
Jeff Schiller
Reported 2009-11-05 11:06:49 PST
* Missing a proper Bug List URL. * Bugs 5527,5970,5973,5976,6719 have been resolved for Filters * Add some new Filter bugs
Attachments
Patch updates the SVG status page and includes proper Bugzilla URL (4.88 KB, patch)
2009-11-05 11:10 PST, Jeff Schiller
no flags
Patch updated to include SVG Filter status from krit (5.74 KB, patch)
2009-11-05 12:43 PST, Jeff Schiller
eric: review+
commit-queue: commit-queue-
Patch without tabs in it. (5.74 KB, patch)
2009-11-05 17:31 PST, Jeff Schiller
no flags
Jeff Schiller
Comment 1 2009-11-05 11:10:16 PST
Created attachment 42580 [details] Patch updates the SVG status page and includes proper Bugzilla URL I think Dirk should review the Filters section.
Dirk Schulze
Comment 2 2009-11-05 12:16:29 PST
Hm. We should be fair and update the status of some filters to Unimplemented: feDisplacementMap, feImage, feDiffuseLightning, feSpecularLigthning, feDistantLight, fePointLight, feSpotLight. It's maybe usefull to mention that it's neccessary to enable filters :-).
Jeff Schiller
Comment 3 2009-11-05 12:28:37 PST
Ok, I can do that. Unimplemented or partial? I guess there are no open bugs for those yet? Also, what is the status of feGaussianBlur? I have 'partial' at the moment.
Dirk Schulze
Comment 4 2009-11-05 12:34:31 PST
(In reply to comment #3) > Ok, I can do that. Unimplemented or partial? Unimplemented, we don't have support for them. > Also, what is the status of feGaussianBlur? I have 'partial' at the moment. I hope that we have a complete implementation :-)
Jeff Schiller
Comment 5 2009-11-05 12:43:37 PST
Created attachment 42587 [details] Patch updated to include SVG Filter status from krit
Eric Seidel (no email)
Comment 6 2009-11-05 15:24:51 PST
Comment on attachment 42587 [details] Patch updated to include SVG Filter status from krit OK. I bet there are more updates needed too. But this looks fine. Adding cq+ since you're not a committer to my knowledge.
WebKit Commit Bot
Comment 7 2009-11-05 15:40:14 PST
Comment on attachment 42587 [details] Patch updated to include SVG Filter status from krit Rejecting patch 42587 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: /webkit/trunk ... M WebKitSite/ChangeLog M WebKitSite/projects/svg/status.xml A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/WebKitSite/projects/svg/status.xml Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/libexec/git-core//git-svn line 469
Jeff Schiller
Comment 8 2009-11-05 17:31:37 PST
Created attachment 42612 [details] Patch without tabs in it. Sigh. I hope this works, I used 'detab' in TextWrangler (though I did see a WebKitTools/Scripts/wkstyle) Eric is correct, I do not have commit access so please commit-queue+
WebKit Commit Bot
Comment 9 2009-11-06 10:32:27 PST
Comment on attachment 42612 [details] Patch without tabs in it. Clearing flags on attachment: 42612 Committed r50601: <http://trac.webkit.org/changeset/50601>
WebKit Commit Bot
Comment 10 2009-11-06 10:32:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.