Bug 31159 - Fix branchDouble behaviour on ARM JIT.
Summary: Fix branchDouble behaviour on ARM JIT.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 31050
  Show dependency treegraph
 
Reported: 2009-11-05 03:09 PST by Zoltan Herczeg
Modified: 2009-11-05 23:29 PST (History)
3 users (show)

See Also:


Attachments
proposed patch (5.88 KB, patch)
2009-11-05 05:59 PST, Zoltan Herczeg
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2009-11-05 03:09:02 PST
BranchDouble behaviour is reworked on x86, and all jit ports should follow the new, clean behaviour

See bug 31104 and bug 31151
Comment 1 Zoltan Herczeg 2009-11-05 05:59:25 PST
Created attachment 42565 [details]
proposed patch
Comment 2 Gavin Barraclough 2009-11-05 15:44:20 PST
Comment on attachment 42565 [details]
proposed patch

Huh, I guess I just don't think like an ARM programmer yet - hadn't thought of the predicated compare, that's neat, will be stealing that for ARMv7 too. ;-)

r+.
Comment 3 Csaba Osztrogonác 2009-11-05 23:29:23 PST
(In reply to comment #2)
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/ARMAssembler.h
Sending        JavaScriptCore/assembler/MacroAssemblerARM.h
Transmitting file data ...
Committed revision 50593.