Bug 311587 – [first-letter] Hovering over ::first-letter text shows pointer cursor instead of I-beam

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[alan]

ssia

[alan]

Created attachment 478936 [details]
Patch

[Antti Koivisto]

Comment on attachment 478936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=478936&action=review

> Source/WebCore/rendering/RenderTextFragment.cpp:119
> +    if (textNode())
> +        return RenderText::nodeForHitTest();
> +
> +    // The anonymous first-letter text has no DOM node. Resolve to the DOM text
> +    // node via the remaining fragment so cursor and selection work.
> +    if (auto* parent = dynamicDowncast<RenderBoxModelObject>(this->parent()); parent && parent->isFirstLetter()) {
> +        if (auto* remainingText = parent->firstLetterRemainingText())
> +            return remainingText->textNode();
> +    }
> +    return RenderText::nodeForHitTest();
> +}

could test !textNode() instead and have one less return paths.

[alan]

Created attachment 478948 [details]
Patch

[alan]

Created attachment 478955 [details]
[fast-cq]Patch

[EWS]

Committed 310730@main (ff9a8d3fa6f2): <https://commits.webkit.org/310730@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 478955 [details].

[Radar WebKit Bug Importer]

<rdar://problem/174258447>