Bug 31158 - [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
Summary: [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Antonio Gomes
Keywords: Qt
Depends on:
Blocks: 30573
  Show dependency treegraph
Reported: 2009-11-05 02:25 PST by Antonio Gomes
Modified: 2009-11-08 19:13 PST (History)
0 users

See Also:

(committed in r50621) patch (5.78 KB, patch)
2009-11-05 04:08 PST, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2009-11-05 02:25:50 PST
qt drt's WorkQueue has the now obsolete queueScript method. It is being called by no one now, and got replaced in mac DRT by queueNonLoadingScript and queueLoadingScript.

$ vim LayoutTests/ChangeLog-2009-06-16 +8615

 * http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a
 script that can instead just be run immedidately.

 * http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of
 queueScript for scripts that don't involve submitting a form. Use queueLoadingScript
 for scripts that do involve submitting a form.
Comment 1 Antonio Gomes 2009-11-05 04:08:14 PST
Created attachment 42554 [details]
(committed in r50621) patch

make removed queueScript (no being used by any layout test) and add queueNonLoadingScript and queueLoadingScript.
Comment 2 Holger Freyther 2009-11-07 01:06:19 PST
Comment on attachment 42554 [details]
(committed in r50621) patch

Looks fine
Comment 3 Antonio Gomes 2009-11-08 09:28:05 PST