Bug 31152 – Fix ASSERT(currentStyle = renderStyle())

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Yuta Kitamura]

In WebCore/dom/Element.cpp, line 762:
    ASSERT(currentStyle = renderStyle());

Clearly this doesn't do what we expected it to do...

[Yuta Kitamura]

Created attachment 42545 [details]
Fix ASSERT(currentStyle = renderStyle()).

[Alexey Proskuryakov]

Comment on attachment 42545 [details]
Fix ASSERT(currentStyle = renderStyle()).

Wow. r=me

The ChangeLog is not in great shape - why repeat the same line twice, for example? Also, the line saying 'We should have used "==" instead of "=". should go after the automatically inserted function name (pseudoStyleCacheIsInvalid), because it describes what was changed in that particular function.

[Yuta Kitamura]

Thanks for your comment! I'll be more careful in writing Changelog.

[Eric Seidel (no email)]

Comment on attachment 42545 [details]
Fix ASSERT(currentStyle = renderStyle()).

Actually, cq-.  I really think we should fix the ChangeLog before landing this.

[Yuta Kitamura]

(In reply to comment #4)
> (From update of attachment 42545 [details])
> Actually, cq-.  I really think we should fix the ChangeLog before landing this.

Thanks. I'll do it.

[Yuta Kitamura]

Created attachment 42628 [details]
Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog)

[Eric Seidel (no email)]

Comment on attachment 42628 [details]
Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog)

Looks great!  Thanks for fixing the ChangeLog nit.

[WebKit Commit Bot]

Comment on attachment 42628 [details]
Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog)

Clearing flags on attachment: 42628

Committed r50592: <http://trac.webkit.org/changeset/50592>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.