WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31149
Calling databaseIdentifier on LocalStorage's background thread is not safe.
https://bugs.webkit.org/show_bug.cgi?id=31149
Summary
Calling databaseIdentifier on LocalStorage's background thread is not safe.
Jeremy Orlow
Reported
2009-11-04 19:03:44 PST
Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread is not safe. databaseIdentifier does a bunch of string concatenation which ref-counts StringImpls in some cases. This was caught by valgrind thread sanitizer:
http://code.google.com/p/chromium/issues/detail?id=25645
There's no way to test for such racyness, unfortunately.
Attachments
Patch
(4.42 KB, patch)
2009-11-04 19:05 PST
,
Jeremy Orlow
fishd
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jeremy Orlow
Comment 1
2009-11-04 19:05:58 PST
Created
attachment 42537
[details]
Patch
Jeremy Orlow
Comment 2
2009-11-05 00:58:56 PST
Committed
r50557
: <
http://trac.webkit.org/changeset/50557
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug