Bug 31139 – Web Inspector: Make resource-related records in timeline actually take some time.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Currently resource loading is captured as three dots:
- send request, 
- receive response, 
- finish load

Not too useful. I'd like to show that it too XX many seconds to receive response, X many seconds to finish loading once response is there.

[Pavel Feldman]

Created attachment 42512 [details]
[PATCH]

[Pavel Feldman]

Created attachment 42513 [details]
[IMAGE]

[Timothy Hatcher]

Comment on attachment 42512 [details]
[PATCH]

I don't think this is right. In principle the change sounds good, but the screenshot does not have the 3 bars lining up like I would expect. I don't expect overlap, but I see significant overlapping.

Also the "Send Request" row are not using showing the WebInspector.displayNameForURL for some reason, it is the full URL.

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 42512 [details])
> I don't think this is right. In principle the change sounds good, but the
> screenshot does not have the 3 bars lining up like I would expect. I don't
> expect overlap, but I see significant overlapping.
> 

I think the overlap is there due to rendering (borders, margins, etc.). Absolute timing for those does not overlap.

> Also the "Send Request" row are not using showing the
> WebInspector.displayNameForURL for some reason, it is the full URL.

Will Fix.

[Pavel Feldman]

Created attachment 42548 [details]
[IMAGE] Minimum length causes overlapping. 'send request' is supposed to be 0 length...

Also the all use displayNameForURL. It is just that the timeline entry is there before the resource for 'Send Request', so it only gets domain trimmed. We should update it upon receive response or something.

[Pavel Feldman]

Created attachment 42549 [details]
[IMAGE] Proper min-width and negative margin.

[Timothy Hatcher]

Comment on attachment 42512 [details]
[PATCH]

r+ with the min-width fix.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r50560

(landed with margin fix and start loading url fix)