Bug 31130 – Web Inspector: Add basic support for resource events and marks. Couple of drive-by fixes. Enabling the panel!

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Time to enable...

[Pavel Feldman]

Created attachment 42495 [details]
[PATCH]

[Timothy Hatcher]

Comment on attachment 42495 [details]
[PATCH]

> +    this._resourceUrls = {};

Should be _resourceURLs


> +            return record.data.x + ", " + record.data.y + ", " + record.data.width + ", " + record.data.height;

Maybe we should just show width x height. I am not sure location will be much use. That detail coudl be in the popup we plan to add. width and height is more usefual since it gives you an idea how big.


> +        case WebInspector.TimelineAgent.RecordType.ResourceSendRequest:
> +            this._resourceUrls[record.data.identifier] = record.data.url;
>              return record.data.url;
> +        case WebInspector.TimelineAgent.RecordType.ResourceReceiveResponse:
> +        case WebInspector.TimelineAgent.RecordType.ResourceFinish:
> +            return this._resourceUrls[record.data.identifier];

These two returns should use WebInspector.displayNameForURL().


> +        case WebInspector.TimelineAgent.RecordType.MarkTimeline:
> +            return record.data.message;

Hmm I am not sure the whole message should be in the sidebar, but I guess it is their fault of it is long.


> +            dataElement.title = this._record.details;

What is .details?

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 42495 [details])
> > +    this._resourceUrls = {};
> 
> Should be _resourceURLs
> 

Done.

> 
> > +            return record.data.x + ", " + record.data.y + ", " + record.data.width + ", " + record.data.height;
> 
> Maybe we should just show width x height. I am not sure location will be much
> use. That detail coudl be in the popup we plan to add. width and height is more
> usefual since it gives you an idea how big.
>

Done.
 
> 
> > +        case WebInspector.TimelineAgent.RecordType.ResourceSendRequest:
> > +            this._resourceUrls[record.data.identifier] = record.data.url;
> >              return record.data.url;
> > +        case WebInspector.TimelineAgent.RecordType.ResourceReceiveResponse:
> > +        case WebInspector.TimelineAgent.RecordType.ResourceFinish:
> > +            return this._resourceUrls[record.data.identifier];
> 
> These two returns should use WebInspector.displayNameForURL().
>

Done.
 
> 
> > +        case WebInspector.TimelineAgent.RecordType.MarkTimeline:
> > +            return record.data.message;
> 
> Hmm I am not sure the whole message should be in the sidebar, but I guess it is
> their fault of it is long.
> 
> 
> > +            dataElement.title = this._record.details;
> 
> What is .details?

A secondary title content. It is not in () in gray and in a tip.